Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize device registry tests #177

Merged
merged 4 commits into from
Mar 27, 2019
Merged

Harmonize device registry tests #177

merged 4 commits into from
Mar 27, 2019

Conversation

M-Gregoire
Copy link
Contributor

@M-Gregoire M-Gregoire commented Feb 20, 2019 •
edited by johanstokking
Loading

Summary:

This PR references #53. It modifies the testing of the device registry to harmonize it with JS and NS.

References #42

Changes:
This PR introduces:

  • A Mock Device Registry for the AS
  • Table Driven Tests
  • More test cases
  • Removal of Redis in the tests

@M-Gregoire M-Gregoire self-assigned this Feb 20, 2019
@M-Gregoire M-Gregoire added the c/application server This is related to the Application Server label Feb 20, 2019
rvolosatovs
rvolosatovs suggested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The already-existing test should not have been removed, please look through #176.
Please restore the original testcases and just add the white-box unit tests you add here.
We will fix any duplicate tests when working on #176

@johanstokking
Copy link
Member

Thou shalt always add a milestone.

@johanstokking johanstokking added this to the February 2019 milestone Feb 21, 2019
@M-Gregoire M-Gregoire force-pushed the issue/53-harmonize-device-registry-testing branch from 1007410 to e0ed767 Compare February 21, 2019 18:08
@M-Gregoire
Copy link
Contributor Author

Thank you for the input @rvolosatovs , I just added the original tests back

@htdvisser htdvisser modified the milestones: February 2019, March 2019 Feb 26, 2019
rvolosatovs
rvolosatovs previously requested changes Mar 4, 2019
View reviewed changes
pkg/applicationserver/applicationserver_util_test.go Outdated Show resolved Hide resolved
pkg/applicationserver/grpc_deviceregistry_test.go Outdated Show resolved Hide resolved
pkg/applicationserver/grpc_deviceregistry_test.go Outdated Show resolved Hide resolved
pkg/applicationserver/grpc_deviceregistry_test.go Outdated Show resolved Hide resolved
@johanstokking
Copy link
Member

@M-Gregoire any update on this?

@M-Gregoire
Copy link
Contributor Author

I've putted that aside, will take care of this tomorrow.

@M-Gregoire M-Gregoire force-pushed the issue/53-harmonize-device-registry-testing branch 2 times, most recently from 6841f94 to c8414c4 Compare March 14, 2019 08:25
@M-Gregoire M-Gregoire requested a review from rvolosatovs March 14, 2019 08:25
@M-Gregoire M-Gregoire requested review from johanstokking and removed request for rvolosatovs March 25, 2019 09:43
@johanstokking
Copy link
Member

@M-Gregoire looks good, taking this over for polishing

@johanstokking johanstokking force-pushed the issue/53-harmonize-device-registry-testing branch from c8414c4 to 58c1438 Compare March 27, 2019 17:13
@johanstokking johanstokking changed the title as: Harmonize device registry tests Harmonize device registry tests Mar 27, 2019
@johanstokking johanstokking added c/join server This is related to the Join Server c/network server This is related to the Network Server labels Mar 27, 2019
@johanstokking johanstokking force-pushed the issue/53-harmonize-device-registry-testing branch from 58c1438 to 3ef6a9a Compare March 27, 2019 17:21
@johanstokking johanstokking merged commit d43e6bf into master Mar 27, 2019
@johanstokking johanstokking deleted the issue/53-harmonize-device-registry-testing branch March 27, 2019 19:44
@johanstokking johanstokking mentioned this pull request Mar 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

@rvolosatovs rvolosatovs rvolosatovs left review comments

Assignees

@johanstokking johanstokking

Labels
c/application server This is related to the Application Server c/join server This is related to the Join Server c/network server This is related to the Network Server
Projects
None yet
Milestone
March 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@M-Gregoire @johanstokking @rvolosatovs @htdvisser