Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fieldmask unmarshaller #19

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Implement fieldmask unmarshaller #19

merged 3 commits into from
Nov 17, 2022

Conversation

ysmilda
Copy link
Contributor

@ysmilda ysmilda commented Nov 16, 2022 •
edited
Loading

Closes #18

@ysmilda ysmilda added this to the Q4 2022 milestone Nov 16, 2022
@ysmilda ysmilda requested a review from adriansmares November 16, 2022 13:41
@ysmilda ysmilda self-assigned this Nov 16, 2022
@ysmilda ysmilda linked an issue Nov 16, 2022 that may be closed by this pull request
Generate unmarshallers always if a submessage has a fieldmask #18
Closed
@github-actions github-actions bot added the needs/triage We still need to triage this label Nov 16, 2022
@ysmilda ysmilda marked this pull request as ready for review November 16, 2022 14:55
adriansmares
adriansmares reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@adriansmares adriansmares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks !

I wish to have the switch branches merged, but otherwise this is good to go.

internal/gen/messages_marshaler.go Show resolved Hide resolved
internal/gen/messages_marshaler.go Show resolved Hide resolved
internal/gen/messages_marshaler.go Show resolved Hide resolved
internal/gen/messages_unmarshaler.go Show resolved Hide resolved
internal/gen/messages_unmarshaler.go Show resolved Hide resolved
internal/gen/messages_unmarshaler.go Show resolved Hide resolved
@ysmilda ysmilda removed the needs/triage We still need to triage this label Nov 17, 2022
@ysmilda ysmilda merged commit 32cc7f6 into main Nov 17, 2022
@ysmilda ysmilda deleted the feature/18-generate-unmarshallers-always-if-a-submessage-has-a-fieldmask branch November 17, 2022 09:09
@adriansmares adriansmares mentioned this pull request Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansmares adriansmares adriansmares left review comments

Assignees

@ysmilda ysmilda

Labels
None yet
Projects
None yet
Milestone
Q4 2022
Development

Successfully merging this pull request may close these issues.

Generate unmarshallers always if a submessage has a fieldmask
2 participants
@ysmilda @adriansmares