Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support V2 API #46

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Support V2 API #46

merged 3 commits into from
Sep 2, 2022

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Sep 2, 2022 •
edited
Loading

Summary

References TheThingsNetwork/lorawan-stack#2798

This PR makes protoc-gen-fieldmask compatible with the V2 protobuf API.

Changes

  • Upgrade to Go 1.19, Protoc 21.5 and google.golang.org/protobuf v1.28.1.
  • Upgrade to protoc-gen-star to v2.0.0-alpha1.
  • Remove support for gogoproto and target goproto directly.

@adriansmares adriansmares changed the title Upgrade to golang protobuf v2 Upgrade to V2 API Sep 2, 2022
@adriansmares adriansmares changed the base branch from master to develop September 2, 2022 16:12
@adriansmares adriansmares force-pushed the feature/proto-v2 branch 3 times, most recently from 6389fa2 to 24e1e18 Compare September 2, 2022 16:35
@adriansmares adriansmares self-assigned this Sep 2, 2022
@adriansmares adriansmares added this to the Q3 2022 milestone Sep 2, 2022
@adriansmares adriansmares marked this pull request as ready for review September 2, 2022 17:12
@adriansmares adriansmares merged commit 51d4e15 into develop Sep 2, 2022
@adriansmares adriansmares deleted the feature/proto-v2 branch September 2, 2022 17:13
@adriansmares adriansmares mentioned this pull request Sep 2, 2022
Merged
@adriansmares adriansmares changed the title Upgrade to V2 API Support V2 API Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adriansmares adriansmares

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adriansmares