Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation of non-nullable fields #25

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Fix validation of non-nullable fields #25

merged 2 commits into from
Feb 26, 2019

Conversation

rvolosatovs
Copy link
Contributor

Summary:

References #21 bufbuild/protoc-gen-validate#52
Fixes validators for non-nullable fields

Changes:

@rvolosatovs rvolosatovs added this to the February 2019 milestone Feb 26, 2019
@rvolosatovs rvolosatovs self-assigned this Feb 26, 2019
htdvisser
htdvisser approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@rvolosatovs rvolosatovs merged commit cbc52bc into master Feb 26, 2019
@rvolosatovs rvolosatovs deleted the fix/non-nullable branch February 26, 2019 13:04
This was referenced Feb 26, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htdvisser htdvisser htdvisser approved these changes

Assignees

@rvolosatovs rvolosatovs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvolosatovs @htdvisser