Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Infantry Muzzle Flash Stuck During Transition Animations #938

Merged
merged 5 commits into from
Aug 20, 2022
Merged

Fix: Infantry Muzzle Flash Stuck During Transition Animations #938

merged 5 commits into from
Aug 20, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 20, 2022 •
edited
Loading

before

muzzle_flash_before.mp4

after

muzzle_flash_after.mp4

  • Red Guard / Minigunner

  • Ranger

  • Angry Mob

  • Note: muzzle flash, including glow are still drawn during the actual fire animation

  • Also note that this bug happens sporadically and is apparently more likely on night or snow maps

@commy2 commy2 added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker labels Aug 20, 2022
@commy2
Copy link
Collaborator Author

commy2 commented Aug 20, 2022

Looks done, unless someone finds another unit affected by this.

@xezon
Copy link
Collaborator

xezon commented Aug 20, 2022

Perhaps Burton and Jarmen?

@commy2
Copy link
Collaborator Author

commy2 commented Aug 20, 2022

Tested both Jarmen and Burton. Burton has no transitions firing->standing and vice versa, so not a problem with him.
Jarmen apparenlty doesn't even have muzzle flash.
However, I found that the same bug happens with the pistol and AK47 Angry Mobs.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 20, 2022

Jarmen using flashhider to not reveal his position too easy 😄

@commy2
Copy link
Collaborator Author

commy2 commented Aug 20, 2022

Done.

@commy2 commy2 changed the title Fix: Ranger/Red Guard/Rebel Muzzle Flash Stuck During Transition Animations Fix: Infantry Muzzle Flash Stuck During Transition Animations Aug 20, 2022
@commy2 commy2 merged commit 028123f into main Aug 20, 2022
@commy2 commy2 deleted the fix-derp-muzzle-flash branch August 20, 2022 18:17
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Infantry Muzzle Flash Stuck During Transition Animations (#938)
d45bc97
@xezon xezon added USA Affects USA faction China Affects China faction GLA Affects GLA faction labels Mar 19, 2023
@commy2 commy2 mentioned this pull request Jul 29, 2023
Closed
This was referenced Aug 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Bug Something is not working right China Affects China faction GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @xezon @ImTimK