Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Some American And Chinese Units Use GLA Death Scream When Gamma Poisoned #92

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Fix: Some American And Chinese Units Use GLA Death Scream When Gamma Poisoned #92

merged 1 commit into from
Aug 29, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 28, 2021

ZH 1.04:

  • When poisoned with Anthrax Gamma only (pink puddles), some units use the GLA death scream instead of the intended USA or China death scream.

After this patch:

  • All units use the correct scream when dying by Anthrax Gamma poison.

@commy2 commy2 added the Bug Something is not working right label Aug 28, 2021
@xezon xezon self-requested a review August 29, 2021 11:21
xezon
xezon approved these changes Aug 29, 2021
View reviewed changes
Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice fix!

@commy2 commy2 merged commit f2b0f52 into main Aug 29, 2021
@commy2 commy2 deleted the fix-death-by-poison-voice-effect branch August 29, 2021 11:25
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Some American And Chinese Units Use GLA Death Scream When Gamma …
382003d 
…Poisoned (#92)
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction China Affects China faction Audio Is audio related labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Audio Is audio related Bug Something is not working right China Affects China faction Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @xezon