Fix: Prevent Hijacker From Stealing Combat Bike #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
added
Bug
|
In this change you do touch GC units. In some other change you advised me to not change GC units. Any guidelines on when and when not to touch? As for the essence of this change, this looks good to me. Combat Bikes are practically never stolen in regular competitive matches. |
Huh, where? Always fix them, as they appear in the campaign. |
|
Ups. I can not recall which one. But it was a recent one. |
|
All I remember is that I said not to bother with CINE units. |
|
Ah. That could be yes. Perhaps I am confused. |
xezon
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes Combat Bikes immune to being hijacked.
Rationale
Logically it makes no sense to steal a Combat Bike with rider on top when you think about it. And it leads to funny bugs, worst of which is trapping an enemy Jarmen Kell.