Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mixing Battle Masters From Different Sub-Factions Does Not Grant Horde Bonus #255

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 9, 2021

ZH 1.04

  • 4 Nuke Battle Masters and 1 Tank Battle Master do not count as a Horde, but 4 Nuke Tank Hunters and 1 Tank Tank Hunter do.
  • The unit type has to match exactly instead of having any of 5 hordable tanks\vehicles.

After ZH 1.04

  • Any 5 Battle Masters will form a horde, no matter what sub-faction they are from.

I think this is a thing, because in CCG only one vehicle with horde existed, while there always were two different infantry units.

@commy2 commy2 added the Bug Something is not working right label Sep 9, 2021
Behavior = HordeUpdate ModuleTag_04
RubOffRadius = 150 ; if I am this close to a real hordesman, I will get to be an honorary hordesman
UpdateRate = 1000 ; how often to recheck horde status (msec)
Radius = 75 ; how close other units must be to us to count towards our horde-ness (~30 feet or so)
KindOf = VEHICLE ; what KindOf's must match to count towards horde-ness
AlliesOnly = Yes ; do we only count allies towards horde status?
ExactMatch = Yes ; do we only count units of our exact same type towards horde status? (overrides kindof)
ExactMatch = No ; do we only count units of our exact same type towards horde status? (overrides kindof)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this know that another faction Battlemaster is ok for horde but a Gattling Tank is not?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the Gattling tanks have a HordeUpdate module. They would need a HordeUpdate module, that is also set to ExactMatch = No.

Copy link
Collaborator Author

@commy2 commy2 Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, 5 Hackers and a Red Guard do not grant Horde for the Red Guard either.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. And Tank Hunters? Will 2 Battlemaster Horde with 3 Tank Hunters?

Copy link
Collaborator Author

@commy2 commy2 Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. The HordeModule for the Red Guard and Tank Hunter only counts for KindOf = INFANTRY.
The HordeModule for the Battle Master(s) however only counts for KindOf = VEHICLE.
They do not count cross type.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that sounds very reasonable then.

@xezon xezon self-requested a review September 9, 2021 17:02
@commy2 commy2 merged commit 6ceae80 into main Sep 9, 2021
@commy2 commy2 deleted the fix-cross-faction-battle-master-horde branch September 9, 2021 17:17
xezon pushed a commit that referenced this pull request Aug 28, 2022
@xezon xezon added Buff Makes a thing more powerful China Affects China faction labels Jan 18, 2023
@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful Bug Something is not working right China Affects China faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants