Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Red Guard animation issues #2292

Merged
merged 3 commits into from
Aug 27, 2023
Merged

Fix: Red Guard animation issues #2292

merged 3 commits into from
Aug 27, 2023

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 26, 2023

  • enable injured standing and moving transition
  • fix standing receive injury animation
  • fix missing dust trails when injured
limping.mp4

@commy2 commy2 added Bug Something is not working right Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker China Affects China faction labels Aug 26, 2023
@commy2
Copy link
Collaborator Author

commy2 commented Aug 26, 2023

Preserving preattack animation + #1123 seems not feasible with current engine.

@commy2 commy2 marked this pull request as ready for review August 27, 2023 07:38
@xezon
Copy link
Collaborator

xezon commented Aug 27, 2023

When injured Red Guard starts moving, there is a small hick up in the transition. I assume this cannot be fixed without touching animations?

@commy2
Copy link
Collaborator Author

commy2 commented Aug 27, 2023

Ah, this is beause the movement animation itself starts on a random frame, instead of the first frame.

Could fix that, however, it would mean that mass moving injured red guards have a synched up animation instead of a shifted phase one, if you can follow.

@xezon
Copy link
Collaborator

xezon commented Aug 27, 2023

Oh

@commy2
Copy link
Collaborator Author

commy2 commented Aug 27, 2023

Variant 1

var1.mp4
  • Movement loop starts on random frame, has hickup between starting-to-move and moving loop

Variant 2

var2.mp4
  • Movemnt loop not random, no hickup between starting-to-move and moving loop

@commy2
Copy link
Collaborator Author

commy2 commented Aug 27, 2023

I'm for Nr. 2

@commy2
Copy link
Collaborator Author

commy2 commented Aug 27, 2023

lgtm

@commy2 commy2 merged commit e97545a into main Aug 27, 2023
@commy2 commy2 deleted the fix-red-guard-animations branch August 27, 2023 09:55
@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 27, 2023

I prefer the random star, looks more realistic , the hickup is barely noticeable, in fact, i still don't see it

@commy2
Copy link
Collaborator Author

commy2 commented Aug 27, 2023

I want to cry.

@xezon
Copy link
Collaborator

xezon commented Aug 27, 2023

Variant 2 looks good to me.

@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 29, 2023

Variant 2 is ugly and much more noticeable, walking uniformly while injured is just lol

Variant 1, i barley just noticed the hiccup, it's very minuscule, not noticable without thorough investigation and even can be imagined sometimes, i started looking at variant 2 after and i started doubting myself that i saw hiccups there too, that's how minuscule it is, also the randomization is very cool and i wouldn't wanna get rid of it for that

@commy2
Copy link
Collaborator Author

commy2 commented Aug 29, 2023

Rarely will you mass move injured units though. It is more likely you have one of them. The stutter can be large or small, depending on where the RANDOMSTART decides to begin the animation.

@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 29, 2023

I've yet to see the stutter be highly visible, i don't see it as an issue here.

Perhaps take another opinion on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right China Affects China faction Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants