Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak: Paradrop Rangers and Missile Defenders in batches #2272

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 22, 2023

With this change, the Rangers and Missile Defenders are created in batches of 5, because all Rangers, then all MDs looks strange to me.

@commy2 commy2 added the Patch104p Is specific to this project label Aug 22, 2023
@xezon
Copy link
Collaborator

xezon commented Aug 22, 2023

What about this one? #2057

@commy2
Copy link
Collaborator Author

commy2 commented Aug 22, 2023

Alzheimers. I don't remember that.

Although spawning 1-1-1-1-1-1 is equally strange looking. Can we agree on 2-2-1 -- 2-2-1 or something instead?

@xezon
Copy link
Collaborator

xezon commented Aug 22, 2023

The disadvantage of opening 10000 Pulls :D

Yeah not sure what pattern is best here.

@commy2
Copy link
Collaborator Author

commy2 commented Aug 22, 2023

(3-2) times n is pretty straight forward. Paradrop 1 is just first unit type, then second unit type; Paradrop 2 and 3 are just multiples of that.

@xezon
Copy link
Collaborator

xezon commented Aug 23, 2023

Do you prefer 3-2-3-2 over 1-1-1-1-1-1-1-1-1 ?

@commy2
Copy link
Collaborator Author

commy2 commented Aug 23, 2023

Yes, definitely. 1-1-1-1-1 is just as bad as all-rest

Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@xezon
Copy link
Collaborator

xezon commented Aug 23, 2023

I like more mix better.

@commy2 commy2 merged commit 5538991 into main Aug 25, 2023
@commy2 commy2 deleted the paradrop-batches branch August 25, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch104p Is specific to this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants