Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: infantry stuck in walk animation when dying #2175

Merged
merged 43 commits into from
Jul 30, 2023
Merged

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Jul 30, 2023

Purely visual

  • Ranger
  • MD
  • Pathfinder
  • Burton
  • CIA Agent
  • Biohazard
  • USA Officer
  • Pilot
  • Red Guard
  • Minigunner
  • Tank Hunter
  • Hacker
  • Lotus
  • China Officer
  • Ambassador
  • Worker
  • Rebel
  • Tox Rebel
  • RPG Solider
  • Tox RPG Soldier
  • Mr. T
  • Jarmen Kell
  • Saboteur
  • Hijacker
  • Stinger Trooper
  • Sniper
  • misc units
  • test with random units

@commy2 commy2 added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction China Affects China faction GLA Affects GLA faction Civilian Affects Civilian faction Boss Affects Boss faction labels Jul 30, 2023
@commy2
Copy link
Collaborator Author

commy2 commented Jul 30, 2023

Intermediate state. Fix applied to USA units, except Burton:

stuck.mp4

as expected, fix works as Rangers die normally while Burton remains stuck

@commy2 commy2 removed the Civilian Affects Civilian faction label Jul 30, 2023
@commy2
Copy link
Collaborator Author

commy2 commented Jul 30, 2023

ready

@xezon
Copy link
Collaborator

xezon commented Jul 30, 2023

What about all the civilian guys? And the Cine and Angry Mob guys? Would it hurt to add?

@commy2
Copy link
Collaborator Author

commy2 commented Jul 30, 2023

civilian guys

If there is a way to reproduce the issue on them, sure. But how would they end up in a transport?

Angry Mob

Same, can't enter vehicles.

Cine

No point, they're hopelessly outdated already in 1.04. Most are CCG state. In general, don't mess with cinematics. They have specific changes for the cutscene they appear in. If the death animation were an issue in those cutscenes, it would've been fixed or worked around already.

@xezon
Copy link
Collaborator

xezon commented Jul 30, 2023

I would have treated all infantry setups equally. Reason being, consistent setups are easier to manage and also avoid wrong setups if a Mod creator decides to use some of the untreated objects as new faction units. For example someone may add a Molotov soldier to GLA.

@commy2
Copy link
Collaborator Author

commy2 commented Jul 30, 2023

Well, it definitely should be added to the UNSoldier.

Will also treat the civies and maybe Mobsters. Still don't like messing with cinematics though.

@commy2
Copy link
Collaborator Author

commy2 commented Jul 30, 2023

  • UNSoldier
  • MogadishuFemaleCivilian01
  • MogadishuFemaleCivilian02
  • MogadishuMaleCivilian01
  • MogadishuMaleCivilian02
  • MogadishuMaleCivilian03
  • GenericFemale01
  • GenericFemale02
  • GenericMale01
  • GenericMale02
  • AmericanFarmer01
  • AsianFarmer01
  • AsianFarmer02
  • AsianFarmer3
  • HomelessGuy :(

@commy2
Copy link
Collaborator Author

commy2 commented Jul 30, 2023

Mob should get their own PR. They have different issues anyway.

@commy2 commy2 merged commit f5b161b into main Jul 30, 2023
@commy2 commy2 deleted the fix-walking-dead branch July 30, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Boss Affects Boss faction Bug Something is not working right China Affects China faction GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stunwalking infantry displays wrong death animation
2 participants