Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Streamline key mappings of China Mines upgrades #2093

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Jul 10, 2023

This change streamlines the key mappings of China Mines upgrades. This makes it a bit easier to learn and operate. Optional bundle only.

Original

Language Land Mines key Neutron Mines key
US L M
DE L M
FR M M
ES M M
IT M M
KO L M
ZH L M
BP M M
PL M M

Patched (Optional)

Language Land Mines key Neutron Mines key
US M M
DE M M
FR M M
ES M M
IT M M
KO M M
ZH M M
BP M M
PL M M

@xezon xezon added Design Is a matter of game design Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker China Affects China faction Text Is text, string, localization related labels Jul 10, 2023
@xezon
Copy link
Collaborator Author

xezon commented Jul 10, 2023

Not clear to me if this is desired. But the L, M key mapping looks silly.

@xezon
Copy link
Collaborator Author

xezon commented Jul 10, 2023

The least we can do is put this in Optional bundle, so that new players can have better key mapping here.

@MTKing4
Copy link
Collaborator

MTKing4 commented Jul 10, 2023

i think it's better to give them separate keys, L for Land mines and M for Neutron

also what happens if you select buildings with different mines?? can't upgrade either?

@commy2
Copy link
Collaborator

commy2 commented Jul 10, 2023

You can only ever select 1 building at once, so no multi select issues on buildings.

@MTKing4
Copy link
Collaborator

MTKing4 commented Jul 11, 2023

Ah yeah true.

Still, I'm used to the L key for mines and i wouldn't wanna change it

@xezon
Copy link
Collaborator Author

xezon commented Jul 11, 2023

I will demote this to Optional bundle.

@xezon xezon added Optional Is optional content and removed Controversial Is controversial Design Is a matter of game design labels Aug 13, 2023
@xezon
Copy link
Collaborator Author

xezon commented Aug 13, 2023

Demoted to Optional bundle.

@xezon
Copy link
Collaborator Author

xezon commented Aug 13, 2023

Documentation added. Works.

@xezon xezon merged commit 6fb6f5a into main Aug 13, 2023
@xezon xezon deleted the text-landmines-key branch August 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
China Affects China faction Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content Text Is text, string, localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants