Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Improve voice setup of China Overlord #1924

Merged
merged 3 commits into from
May 21, 2023
Merged

Change: Improve voice setup of China Overlord #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
674ca47
Change: Add unused voice to China Overlord unload (#1924)
xezon May 9, 2023
799950c
Change: Optionally improve voice setup of China Overlord creation (#1…
xezon May 9, 2023
121dbdd
Add voice voveatd to OverlordTankVoiceAttack
xezon May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Patch104pZH/Design/Changes/v1.0/1924_unused_overlord_voices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
date: 2023-05-05

title: Adds unused voice variation(s) to China Overlord

changes:
- tweak: Adds unused voice "They will beg for mercy" to OverlordTankVoiceAttack.
- tweak: Adds unused voice "Leave now" to OverlordTankVoiceUnload.

labels:
- audio
- china
- design
- enhancement
- minor
- v1.0

links:
- https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1924

authors:
- xezon
8 changes: 6 additions & 2 deletions Patch104pZH/GameFilesEdited/Data/INI/Voice.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2072,8 +2072,10 @@ AudioEvent OverlordTankVoiceMove
Type = ui voice player
End

; Patch104p @tweak xezon 05/05/2023 Adds former unused sound(s) voveatd (#1924)
; voveatd "They will beg for mercy"
AudioEvent OverlordTankVoiceAttack
Sounds = voveata voveatb voveatc voveate voveatf voveatg vovecrb
Sounds = voveata voveatb voveatc voveate voveatf voveatg vovecrb voveatd
Control = random
Volume = 90
Type = ui voice player
Expand All @@ -2086,8 +2088,10 @@ AudioEvent OverlordTankVoiceCrush
Type = ui voice player
End

; Patch104p @tweak xezon 05/05/2023 Adds former unused sound(s) voveuna (#1924)
; voveuna "Leave now"
AudioEvent OverlordTankVoiceUnload
Sounds = voveunb ;voveuna voveunc
Sounds = voveuna voveunb ; voveunc
Control = random
Volume = 90
Type = ui voice player
Expand Down