Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Misspelled sounds in audio events #1913

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix: Misspelled sounds in audio events #1913

merged 1 commit into from
May 19, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented May 7, 2023

This change fixes misspelled sounds in audio events. Some of these audio events are unused in the game.

CarDamagedMoveLoop

  • gcardami

MissionAccomplishedSound

  • ucheergl

HackerWeaponLoop

  • ihaclo1a, Hack sequence now has initiation sound like Black Lotus has.

CivilianArabFemaleDie

  • icifcdif, Scream

FireStormLoop

  • gstolo2a gstolo2b gstolo2c, China Fire Storms now loop correctly

RangerVoiceClearBuilding

  • irancld "Little house party"

HumveeVoiceUnload

  • vhumunc "It's been real"

POWTruckUSAVoicePickup

  • vpoupib "Yeah there should be enough room for him"

RedGuardVoiceLaugh

  • iredlaa "Ahh hahaha"

DozerChinaVoiceClearMine

  • vdocclc "Our people will be safer", Removed

NukeCannonVoiceUnDeploy

  • vnukd2c "Folding up"

ScorpionTankVoiceAttackRocket

  • vscoa2b "Sending the missile"

QuadCannonVoiceCrush

  • vquacra "The worms should like the dirt"

WorkerVoiceGarrison

  • iworgaa "I will go in that building"

WorkerVoiceRepair

  • iworrea "I should repair that"

HijackerVoiceAttack

  • ihijatc "It will be mine"

@xezon xezon added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Audio Is audio related labels May 7, 2023
@ThePredatorBG
Copy link
Collaborator

ThePredatorBG commented May 7, 2023

The ucheer sound file of the MissionAccomplishedSound event exists and does not look like a misspell. The ucheergl file is used on the CheerGLA event.

@xezon
Copy link
Collaborator Author

xezon commented May 7, 2023

The ucheer sound file of the MissionAccomplishedSound event exists and does not look like a misspell. The ucheergl file is used on the CheerGLA event.

I am unable to make this observation on the files I have here. ucheer exists in Speech, but not in Sounds. So ucheer should not load from AudioEvent definition.

relPath,size,md5,sha256
Data/Audio/Sounds/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Sounds/Brazilian/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Sounds/Chinese/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Sounds/English/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Sounds/French/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Sounds/German/ucheergl.wav,332426,75cf27a6e74e4126d9c5971d3a68a4f9,08d22e587b144c84143354a4b6977dab9e4d15c94bbd9cb0624f765f3bfa63f2
Data/Audio/Sounds/Italian/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Sounds/Korean/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Sounds/Polish/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Sounds/Spanish/ucheergl.wav,332426,b8fc14469521818b1c595441c1218c9a,ae77b0f5c4d97d51807dc6bd016fbf675ef86e89a9d532bc162061aa08a3e365
Data/Audio/Speech/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211
Data/Audio/Speech/Brazilian/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211
Data/Audio/Speech/Chinese/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211
Data/Audio/Speech/English/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211
Data/Audio/Speech/French/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211
Data/Audio/Speech/German/ucheer.wav,347258,16b7e36bc570cad09a419b8df9047d79,dd50f927bbdee552d8c2747d975430b7d655e0e967bb083fdf613aa2ce50877e
Data/Audio/Speech/Italian/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211
Data/Audio/Speech/Korean/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211
Data/Audio/Speech/Polish/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211
Data/Audio/Speech/Spanish/ucheer.wav,347258,0248f246042bde37a7c20a0d5d8fff5f,910a2093bdb6881e637bd4d52b75d0b0b6ec2d9b1f39f9f02e006be904276211

@xezon
Copy link
Collaborator Author

xezon commented May 19, 2023

Documentation added. Looks good.

@xezon xezon merged commit 1338612 into main May 19, 2023
@xezon xezon deleted the sounds-misspelled branch May 19, 2023 10:07
xezon added a commit that referenced this pull request May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Is audio related Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants