Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve China Neutron Shell explosion effects #1872

Merged
merged 1 commit into from
May 12, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Apr 24, 2023

This change fixes and improves the China Neutron Shell explosion effects. It no longer shows the explosion effect of the Alpha Aurora and instead just shows the Neutron specific effects and the scattered flares in matching colors and sizes.

  • Removes the Alpha Aurora fuel bomb explosion and smoke
  • Leaves the scattered flares with matching colors and sizes
  • Moves all Neutron particle effects closer to the ground where the shell actually hits
  • Removes one of the dust rings because there are 2 of them moving at different speeds
  • Halves the duration of the remaining dust ring effect
  • Increases speed and reduces lifetime of the neutron rings
  • Gives the outer neutron ring a fixed size to better indicate the weapon effect radius
  • Increases the size growth of the centered neutron flare ball to look a bit more impressive
  • Removes the unnecessary terrain scorch

Original particles

generals.2023-04-24.16-51-39-42.mp4

Patched particles

generals.2023-04-24.17-42-35-34.mp4

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Art Is art related China Affects China faction labels Apr 24, 2023
@xezon xezon force-pushed the fix-neutron-shell-hit-effect branch from 6890e40 to 2dd3bc6 Compare April 24, 2023 16:00
@xezon xezon force-pushed the fix-neutron-shell-hit-effect branch 2 times, most recently from 4c66f2a to e34d5b0 Compare May 2, 2023 18:30
@xezon
Copy link
Collaborator Author

xezon commented May 2, 2023

Documentation added. Looks good.

@ImTimK
Copy link
Collaborator

ImTimK commented May 2, 2023

Looks much better than original!

It fits the type of weaponry and it looks unique now, not like a weird silent Alpha Aurora bomb copy paste.

Maybe we can do something about the sound aswell? The breaking glass sounds so.. cheesy?

@MTKing4
Copy link
Collaborator

MTKing4 commented May 2, 2023

The "breaking Glass" sound is actually for the unman action, you can also hear it with the jarmen snipe, it's not strict for nuke cannon

@ImTimK
Copy link
Collaborator

ImTimK commented May 3, 2023

Yea true, is it extra loud when multiple units get 'sniped' by a neutron?

@xezon
Copy link
Collaborator Author

xezon commented May 3, 2023

I suspect it is this

AudioEvent VehicleSnipeVictim
  Sounds      = gvehsnia
  Priority    = high
  VolumeShift = -15
  Volume      = 70
  Type        = world shrouded everyone
End

No limit.

@xezon xezon force-pushed the fix-neutron-shell-hit-effect branch from e34d5b0 to 08e6ada Compare May 12, 2023 15:11
@xezon xezon merged commit 3871764 into main May 12, 2023
@xezon xezon deleted the fix-neutron-shell-hit-effect branch May 12, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related China Affects China faction Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants