Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Begin sink China Dragon Tank hulk right after the fire effect vanished #1745

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Feb 21, 2023

This change begins to sink China Dragon Tank hulk right after the rubble fire effect vanished. It now sinks after 12000 instead of 14000 milliseconds. This way it does not stay in the world longer than necessary.

@xezon xezon added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker labels Feb 21, 2023
@xezon xezon marked this pull request as ready for review February 21, 2023 20:56
@commy2
Copy link
Collaborator

commy2 commented Feb 22, 2023

Why?

@xezon xezon added the China Affects China faction label Apr 24, 2023
@xezon xezon force-pushed the fix-vehicle-hulk-physics-4 branch from 8d69ee3 to 80d88dd Compare April 24, 2023 17:19
@xezon
Copy link
Collaborator Author

xezon commented Apr 24, 2023

Why?

Looks better. And there is no need to have the Dragon Tank wreck linger too much longer around than every other vehicle wreck.

Documentation added. Looks good.

@xezon xezon merged commit 0a04040 into main Apr 24, 2023
@xezon xezon deleted the fix-vehicle-hulk-physics-4 branch April 24, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
China Affects China faction Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants