Change: Despawn Salvage Crates deterministically after 32500 ms #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Design
Stubbjax
approved these changes
Feb 12, 2023
xezon
force-pushed
the
fix-salvage-4-deletion-randomness
branch
from
854f455
to
b85b6d3
Compare
|
Documentation added. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change despawns Salvage Crates deterministically after 32500 ms instead of sometime between 30000 ms and 35000 ms.
32500 ms because that sits between the former min and mix deletion time of Salvage Crate.
Original
generals.2023-02-12.10-07-52-98.mp4
Patched
generals.2023-02-12.10-06-40-08.mp4
Rationale
Deterministic timings make game events predictable. Randomness typically leads to random outcomes which are generally not desired for core game mechanics that affect the game state.