Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helix Commandset #1532

Merged
merged 2 commits into from
Jan 8, 2023
Merged

Fix Helix Commandset #1532

merged 2 commits into from
Jan 8, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Jan 8, 2023

This change was partially reverted with

Merge with Rebase.

This change puts Helix Bomb Upgrade and Helix Bomb Drop buttons on same Command position for all Helix variants. Additionally, Helix Bomb Upgrade is now greyed out while another upgrade is in production.

No upgrades

shot_20230108_143327_1

Bomb purchased

shot_20230108_143418_3

Bomb Upgrade greyed out

shot_20230108_143340_2

@xezon xezon added Bug Something is not working right Design Is a matter of game design Controversial Is controversial China Affects China faction labels Jan 8, 2023
@ImTimK
Copy link
Collaborator

ImTimK commented Jan 8, 2023

This is nice

@Stubbjax Stubbjax self-requested a review January 8, 2023 13:54
Copy link
Collaborator

@Stubbjax Stubbjax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. The NOT_QUEUEABLE is a nice addition as well; that always bugged me.

xezon added a commit that referenced this pull request Jan 8, 2023
@xezon xezon merged commit f57d8a4 into main Jan 8, 2023
xezon added a commit that referenced this pull request Jan 8, 2023
@xezon xezon deleted the fix-helix-commandset branch January 8, 2023 16:10
@MTKing4
Copy link
Collaborator

MTKing4 commented Jan 9, 2023

I think this adds a new confusion + Problem

The confusion is that i can no longer know if i have the bomb or the upgrade by looking at the icon (i know they have orange and green outlines but it's not very visible, and yes cameo is there but still, less ways to know can be annoying)

The problem is that if i select multiple helixes with 1 having the upgrade i can no longer order a dropping and upgrade Separately

I'm asuming when multiple helixes are selected I'll be forced to buy them all upgrades for the commandset to change to drop, this is a problem

@xezon
Copy link
Collaborator Author

xezon commented Jan 9, 2023

The confusion stems from 2 identical icons doing different things. One icon upgrades, the other icon drops bomb. Both look identical and sit right next to each other.

You are correct. With this change applied, Bomb Upgrade and Bomb Drop can no longer be used with shortcut when 2 Helixes have different Command Set active.

Revert this change?

Note that Infantry Helix has identical behavior in original game, due limited command slots.

shot_20230109_205514_2

@MTKing4
Copy link
Collaborator

MTKing4 commented Jan 10, 2023

The confusion stems from 2 identical icons doing different things. One icon upgrades, the other icon drops bomb. Both look identical and sit right next to each other.

Yes but the severity of the confusion was less before as you could at least tell you have the upgrade when the upgrade commandset gets a darker tone

I think revert, and stick to the different icon solution, i think a Red Bomb facing down icon or Red Target Crosshair icon will look nice and quite straight forward and good looking imo

@MTKing4
Copy link
Collaborator

MTKing4 commented Jan 10, 2023

something like this:

Fun 1

@xezon
Copy link
Collaborator Author

xezon commented Jan 10, 2023

I agree with revert, though it is upsetting that it will be inconsistent with Infantry Helix.

@ImTimK
Copy link
Collaborator

ImTimK commented Jan 10, 2023

I'm a simple user, I just tested Inf Lix, the interface, hotkeys and functionality all works perfectly.

I don't understand for what reason two buttons is preferred? Or even different icons? That only makes things more inconsistent and cluttered.

@Stubbjax
Copy link
Collaborator

It is already the case if a player tries to do the same with the Bunker / Gattling Cannon / Speaker Tower upgrades. The same behaviour applies to the Overlord. I disagree that this change adds any meaningful level of confusion at all, and it may even reduce confusion as there is no longer a behavioural difference between Helixes - and further, between upgrades. Standarding the behaviour with the Infantry Helix is a cleaner solution in this case.

However, the inability to drop bombs if Helixes without the upgrade are in the unit selection is a serious problem that needs to be addressed.

@xezon
Copy link
Collaborator Author

xezon commented Jan 10, 2023

However, the inability to drop bombs if Helixes without the upgrade are in the unit selection is a serious problem that needs to be addressed.

This is the culprit of this change. It cuts functionality.

As for the Attachment upgrades, I am trying to fix it, but so far unsuccessfully. It works correctly on Humvees with Drone Upgrades.

@ImTimK
Copy link
Collaborator

ImTimK commented Jan 10, 2023

Ok sorry, I missed that issue. Personally never ever used it with multiple Lixes at the same time in all of my playtime.

An old idea, what about making the upgrade global with all the same parameters as Rocket Pods? :)

@xezon
Copy link
Collaborator Author

xezon commented Jan 10, 2023

An old idea, what about making the upgrade global with all the same parameters as Rocket Pods? :)

This would solve all Command Set design problems.

@Stubbjax
Copy link
Collaborator

This is the culprit of this change. It cuts functionality.

If that is the case then I would say revert - we do not want to lose functionality.

Personally never ever used it with multiple Lixes at the same time in all of my playtime.

This is also my experience, so the impact may be low and the benefits would likely outweigh the drawbacks. But that may change if the upgrade becomes more appealing.

An old idea, what about making the upgrade global with all the same parameters as Rocket Pods? :)

This would be far too controversial!

@ImTimK
Copy link
Collaborator

ImTimK commented Jan 10, 2023

This would be far too controversial!

Compared to other controversial changes already in the patch? Lol nah.

It's a nice little improvement for a shitty upgrade noone uses.

@Stubbjax
Copy link
Collaborator

This would be far too controversial!

Compared to other controversial changes already in the patch? Lol nah.

It's a nice little improvement for a shitty upgrade noone uses.

What other changes? I think it certainly would be. Especially because there is associated dialogue that would never be heard again.

@ImTimK
Copy link
Collaborator

ImTimK commented Jan 10, 2023

What other changes?

Seems you missed alot

But I can make another controversial upsetting public topic to see what people think.

@Stubbjax
Copy link
Collaborator

What other changes?

Seems you missed alot

But I can make another controversial upsetting public topic to see what people think.

I am interested to know. Probably best to move this discussion to Discord.

@xezon
Copy link
Collaborator Author

xezon commented Jan 10, 2023

Seems you missed alot

This is not a helpful answer to the question. A comparable controversial change was asked for.

I agree with Stubbjax that it would be highly controversial. If my memory is not clouded we have not yet made a change that has changed a unit ability in such a way.

We have report for it here:

@MTKing4
Copy link
Collaborator

MTKing4 commented Jan 10, 2023

I don't recall us merging any controversial change without the majority agreeing to it, that being said, I'd like it if we could agree about adding that bomb upgrade, maybe we can gather public opinion on the matter to see if it's really that controversial

xezon added a commit that referenced this pull request Jan 11, 2023
@xezon xezon added GUI For graphical user interface and removed Controversial Is controversial labels Mar 19, 2023
@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right China Affects China faction Design Is a matter of game design GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

China Helix Nuke/Napalm Bomb has identical icon for different buttons
4 participants