Fix: Streamline drift velocity of prominent smoke and steam particles #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Bug
xezon
force-pushed
the
fix-smoke-steam-drift-velocity
branch
2 times, most recently
from
3e90422
to
24bf1c6
Compare
xezon
force-pushed
the
fix-smoke-steam-drift-velocity
branch
from
24bf1c6
to
92f22d6
Compare
|
Reviewed. Fine tuned DozerSmokeLight, DozerSmokeHeavy, SteamMedium a bit more. Looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smoke and steam particle drift velocity is not consistent. I streamlined the prominent ones based on SteamVent velocity. It drift into similar direction of where clouds move.
Dozer smoke drifted way too much sideways.
Smoldering smoke drifted into opposite direction of Steam.
Some steams had no drift velocity.
There likely are still some inconsistent ones left over, but it is unclear to me how to find all relevant static ones.