Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Animate China War Factory Crane When Repairing Instead Of When Constructing #1393

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Change: Animate China War Factory Crane When Repairing Instead Of When Constructing #1393

merged 1 commit into from
Oct 19, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Oct 19, 2022

1.04

  • Crane on War Factory moves while building a unit.

patch

  • Crane on War Factory moves while repairing a unit instead.
  • You can still tell if a unit is being build, because the baskets filled with molten metal are animated.

@commy2 commy2 added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker labels Oct 19, 2022
xezon
xezon approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@commy2 commy2 merged commit 07f6bd0 into main Oct 19, 2022
@commy2 commy2 deleted the change-repair-crane-china branch October 19, 2022 20:57
@ImTimK ImTimK added China Affects China faction and removed China Affects China faction labels Nov 6, 2022
@xezon xezon added the China Affects China faction label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
China Affects China faction Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @xezon @ImTimK