Match Gattling barrel spin animation speeds with fire rates #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Bug
commy2
approved these changes
Oct 15, 2022
|
Hmm good point. I did not test that. Perhaps for Gattling Tank we would need to set speed to somewhere between firing rate of Vet 0 and Vet 3. Does Overlord/Helix Gattling Cannon change on Veterancy? |
I don't think so. No red tracers at least. |
|
I tested Gattling Tank CONTINUOUS_FIRE_FAST on Vet 1 with RATE_OF_FIRE 120% and Vet 3 with RATE_OF_FIRE 160%, and the muzzle flashes have exact same interval as with Vet 0 with RATE_OF_FIRE 100%. So the barrel spin remains a match. I think there is nothing more to do here. |
…n speed with actual fire rate (#1359)
xezon
force-pushed
the
tweak-gattling-spin-speeds-2
branch
from
799cfdd
to
303852d
Compare
xezon
added a commit
that referenced
this pull request
Oct 29, 2022
xezon
added a commit
that referenced
this pull request
Oct 29, 2022
xezon
added a commit
that referenced
this pull request
Oct 29, 2022
xezon
added a commit
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change matches all Gattling barrel spin animation speeds with their respective fire rates.
This change has multiple commits and should be Merged with Rebase.
The new animation speeds were determined by observing the individual fire rates, barrel spins frame by frame and adjusting the animation speeds accordingly. Surely there is some math to it, but I did not check it.