Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Crusader Wreck Spawned Before Model Disappears #1163

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 8, 2022

From NPM

1.04:

  • 50% chance the Crusader flings away the turret on death, if this happens, the wreck is spawned before the original object is deleted, so two models intersect for ~8 frames.

patch:

  • wreck model spawns at the same time as when original model is deleted

Also changed CINE, because otherwise that unit would be broken with this change.
The fix was done by removing the OCL that spawns the wreck at MIDPOINT and instead adds the entirety of OCL_GenericTankDeathEffect to OCL_CrusaderTurret.

OCL_GenericTankDeathEffect has a bad name. It is specifically for the Crusader, not a generic tank.

@commy2 commy2 added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker NProject Issue has been addressed in NProject Mod labels Sep 8, 2022
Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@xezon xezon merged commit 9700f05 into main Sep 14, 2022
@xezon xezon deleted the fix-crusader-death branch September 14, 2022 07:23
@xezon xezon mentioned this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker NProject Issue has been addressed in NProject Mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants