Fix: Tank Muzzle Flash effects

[xezon]

This change fixes Tank Muzzle Flash effects and texture.

• SmokePuff texture artifacts fixed
• Muzzle Flare fade out fixed
• Muzzle Smoke direction and size fixed

Original

original_muzzle.mp4

Patched

patched_muzzle.mp4

[ImTimK]

probably is more realistic, you can see some smoke come from the barrels irl:

https://youtu.be/was2xsfFgQ0?t=21

Although it's mostly up kicking dust, is there not such effect ingame to use?

edit: Hmmm original muzzle flash itself seems bigger/brighter/longer lasting? Not sure if this part is an improvement.

[xezon]

To improve smoke visual, I now made puff a bit brighter and shifted slight magenta tint to orange tint. This should blend more graciously with Muzzle Flame.

Tested on snow, grass and desert. Looks good.

[commy2]

This looks very nice and indeed similar to what a real life cannon would look like after firing.
Did you come up with this yourself or is this taken from a mod?

[xezon]

I reduced TankMuttleFlashSmoke life time from 50 to 40 frames, because the smoke lingers too long with 50. The TankSmallMuttleFlashSmoke lasts 30 frames. The Nuke Cannon and Battleship smoke remains 50. That looks good to me.

[Stubbjax]

Can we get some video footage of the additional tweaks? I'm not a fan of the strong contrast between the flash and smoke in the original footage.

[xezon]

The image in #1149 (comment) shows latest edit.

Note that particles from first video are Original color, so they cannot be complained against.

[xezon]

Any further opinions on this?

[xezon]

Did you come up with this yourself or is this taken from a mod?

I tweaked it from scratch after I noticed that the Battle Master puff flies downwards.

[xezon]

Is this change good?

[xezon]

Reviewed. The new smoke puff was a bit too bright. Fixed. New smoke puff texture was used on unrelated effects. Reverted. This change now touches Tank effects only.

Tested on Snow, Gras, Desert, Shell Map. Looks good to me.