Fix: Nuke Cannon Shell Detonation Effect Has Offset #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
added
Bug
commy2
force-pushed
the
fix-nuke-cannon-detonation-position
branch
2 times, most recently
from
bc34389
to
0cb3110
Compare
|
This change does not work correctly when targeting unit instead of terrain. Same for both weapons. generals.2022-09-06.12-59-35-71.mp4 |
commy2
force-pushed
the
fix-nuke-cannon-detonation-position
branch
from
0cb3110
to
ca2c14d
Compare
|
Good catch. Dumb game. Should work now. Note to self: Don't test nuke explosion effects on Nuke Battlemasters. |
|
Good to merge? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawns effect via dummy, which should not suffer impressions.