-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Fix and improve the look of China Mine explosion effects #1121
Conversation
A bit too purple? Looks like the Scrin are invading again. |
It is the same color as the mines. Do you think it should be a bit brighter? |
More blue and white, less red. |
Original Neutron a LOT better, new one looks too slow, small and weak and color reminds more of a toxin cloud. New red one is kinda fine too though. Maybe this could improve animation:
|
The OG Neutron always seemed to me like the game is glitching out. It doesn't even look like Nuke Cannon Neutron does. Maybe some inspiration can be found from that (including sound). |
patched_mines2.mp4 |
I strongly prefer the original mine effect for Landmines. I don't see why the explosion has to be red just because the mines themselves glow red. Red explosions make me think of Demogen and his TNT clouds (tank shells, suicide, Bomb Truck, Scud Launcher, Scud Storm etc.) The Neutron mine explosion is indeed whack and should be fixed. Why not make that one closer to what the Nuke Cannon Neutron Shell looks like and call it a day? |
I kinda agree with commy Red Explosion = Demo Maybe just fix the particles with no color change. |
Yeah, goes without saying that particle bug fixes are very much appreciated. But changing colors are "sideways" changes, if you understand what I'm saying, and not direct improvements, and therefore a matter of taste. |
b4283e7
to
ab1788c
Compare
What about this version?
patched_mines_3.mp4 |
This looks good |
Good. Shall we go with it? |
Yes for me |
Last video looks pretty good, neutron explosion is pretty big still, is what I like. I'm also curious what a white flash would look like with neutrons. |
I feel like the flare colours should match or at least be swapped. It's more obvious when you compare side by side: Otherwise I think the size reduction on the neutron mines while keeping the original distinction / feeling is a definite improvement. |
I don't like the Original colors either. But to me it read as if the others want to keep original colors. |
It's just that the first version overdid it a little, like the purple flash looked really toxic or alien-like and the red kinda too "demo'ish". |
In the first version I matched flare colors with actual mine colors. |
Long story short, I agree with Stubjax, last version looks very good, just swap the colors and it's perfect. |
Documentation added. White flash effect re-added to Neutron explosion. Looks good. |
This change improves the look of Mine explosion effects.
Original
Red mines spawn small white flares. Fade out is not smooth.
Purple neutron mines spawn huge yellow flares. Flare lasts shorter than red flare.
original.mp4
Patched
Red mines spawn small red flares. Fade out is smooth.
Purple neutron mines spawn medium purple flares. Flare lasts same time as red flare.
Effects for Neutron Nuke Cannon and EMP Mines remains unchanged.
patched.mp4