Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Fix and improve the look of China Mine explosion effects #1121

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Sep 4, 2022

This change improves the look of Mine explosion effects.

Original

Red mines spawn small white flares. Fade out is not smooth.
Purple neutron mines spawn huge yellow flares. Flare lasts shorter than red flare.

original.mp4

Patched

Red mines spawn small red flares. Fade out is smooth.
Purple neutron mines spawn medium purple flares. Flare lasts same time as red flare.

Effects for Neutron Nuke Cannon and EMP Mines remains unchanged.

patched.mp4

@xezon xezon added Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker labels Sep 4, 2022
@commy2
Copy link
Collaborator

commy2 commented Sep 4, 2022

A bit too purple? Looks like the Scrin are invading again.

@xezon
Copy link
Collaborator Author

xezon commented Sep 4, 2022

It is the same color as the mines. Do you think it should be a bit brighter?

@commy2
Copy link
Collaborator

commy2 commented Sep 4, 2022

More blue and white, less red.

@ImTimK
Copy link
Collaborator

ImTimK commented Sep 4, 2022

Original Neutron a LOT better, new one looks too slow, small and weak and color reminds more of a toxin cloud.

New red one is kinda fine too though.

Maybe this could improve animation:

  • Same overall animation length.
  • Faster initial explosion (expansion part), makes it look powerful I think.
  • Longer smoother fadeout.
  • Keep neutron size.
  • Neutron color more white blue'ish instead of yellow.

@commy2
Copy link
Collaborator

commy2 commented Sep 4, 2022

The OG Neutron always seemed to me like the game is glitching out. It doesn't even look like Nuke Cannon Neutron does. Maybe some inspiration can be found from that (including sound).

@xezon
Copy link
Collaborator Author

xezon commented Sep 5, 2022

  • Red Mine & Neutron Mine flash time reduced from 15 to 10 frames
  • Neutron mine flash size increased from 20 to 30
  • Neutron mine flash color more bright and blue
patched_mines2.mp4

@xezon xezon added the Enhancement Is new feature or request label Sep 5, 2022
@xezon xezon self-assigned this Sep 5, 2022
@commy2
Copy link
Collaborator

commy2 commented Sep 5, 2022

I strongly prefer the original mine effect for Landmines. I don't see why the explosion has to be red just because the mines themselves glow red. Red explosions make me think of Demogen and his TNT clouds (tank shells, suicide, Bomb Truck, Scud Launcher, Scud Storm etc.)

The Neutron mine explosion is indeed whack and should be fixed. Why not make that one closer to what the Nuke Cannon Neutron Shell looks like and call it a day?

@MTKing4
Copy link
Collaborator

MTKing4 commented Sep 5, 2022

I kinda agree with commy

Red Explosion = Demo
Purple Explosion = Gamma

Maybe just fix the particles with no color change.

@commy2
Copy link
Collaborator

commy2 commented Sep 5, 2022

Yeah, goes without saying that particle bug fixes are very much appreciated. But changing colors are "sideways" changes, if you understand what I'm saying, and not direct improvements, and therefore a matter of taste.

@xezon xezon force-pushed the mines-fx branch 4 times, most recently from b4283e7 to ab1788c Compare January 4, 2023 19:01
@xezon
Copy link
Collaborator Author

xezon commented Jan 4, 2023

What about this version?

  • Same colors as per original
  • Neutron Flash is smaller than original
  • Fixed glitches
patched_mines_3.mp4

@MTKing4
Copy link
Collaborator

MTKing4 commented Jan 4, 2023

This looks good

@xezon
Copy link
Collaborator Author

xezon commented Jan 5, 2023

Good. Shall we go with it?

@MTKing4
Copy link
Collaborator

MTKing4 commented Jan 5, 2023

Yes for me

@ImTimK
Copy link
Collaborator

ImTimK commented Jan 5, 2023

Last video looks pretty good, neutron explosion is pretty big still, is what I like.

I'm also curious what a white flash would look like with neutrons.

@Stubbjax
Copy link
Collaborator

Stubbjax commented Jan 8, 2023

What about this version?

* Same colors as per original

* Neutron Flash is smaller than original

* Fixed glitches

I feel like the flare colours should match or at least be swapped. It's more obvious when you compare side by side:

image

Otherwise I think the size reduction on the neutron mines while keeping the original distinction / feeling is a definite improvement.

@xezon
Copy link
Collaborator Author

xezon commented Jan 8, 2023

I don't like the Original colors either. But to me it read as if the others want to keep original colors.

@ImTimK
Copy link
Collaborator

ImTimK commented Jan 8, 2023

It's just that the first version overdid it a little, like the purple flash looked really toxic or alien-like and the red kinda too "demo'ish".

@xezon
Copy link
Collaborator Author

xezon commented Jan 8, 2023

In the first version I matched flare colors with actual mine colors.

@ImTimK
Copy link
Collaborator

ImTimK commented Jan 8, 2023

Long story short, I agree with Stubjax, last version looks very good, just swap the colors and it's perfect.

@xezon xezon added Art Is art related China Affects China faction and removed Controversial Is controversial labels Apr 12, 2023
@xezon xezon removed the Enhancement Is new feature or request label Apr 12, 2023
@xezon
Copy link
Collaborator Author

xezon commented Apr 12, 2023

Documentation added. White flash effect re-added to Neutron explosion. Looks good.

@xezon xezon changed the title Change: Improve Mine explosion effects Change: Fix and improve the look of China Mine explosion effects Apr 12, 2023
@xezon xezon merged commit f9d2531 into main Apr 12, 2023
@xezon xezon deleted the mines-fx branch April 12, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related China Affects China faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants