Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: China Command Center Has Second Clipping Building At Night When Damaged #1090

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 3, 2022

before

shot_20220903_150126_1

after

shot_20220903_152110_1

Note: 'after' is essentially how the building looks already when damaged on day, snow and snow+night maps.

It may be preferable to remove the rogue objects from the model instead.

@commy2 commy2 added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker labels Sep 3, 2022
@xezon
Copy link
Collaborator

xezon commented Sep 3, 2022

The only art changed for nbconyard in NProject are these 4 textures

Art\Textures\nbconyard2_d.dds
Art\Textures\nbconyard2_ds.dds
Art\Textures\nbconyard2_e.dds
Art\Textures\nbconyard2_es.dds

@commy2
Copy link
Collaborator Author

commy2 commented Sep 3, 2022

Texture changes won't fix this. It needs model changes in NBConYard?_DN.W3D, where ? is a sub-faction specific character.

@xezon
Copy link
Collaborator

xezon commented Sep 3, 2022

Yes. There is no conyard model change. Just textures.

@commy2
Copy link
Collaborator Author

commy2 commented Sep 3, 2022

I checked the NProject INI files. The fix is not applied there either. I think this is not fixed in NProject.

A similar PR is this: #133

Instead of INI work-arounds, the model was changed. From my understanding, no HideSubObject work-around could have been applied there, because the issue was with a texture, not with rogue model parts.

I think this PR is most reasonable way to fix this issue.

@commy2 commy2 force-pushed the fix-damaged-china-cc-at-night branch from 77e3bf3 to 36fd6bd Compare September 4, 2022 07:32
@commy2 commy2 force-pushed the fix-damaged-china-cc-at-night branch from 36fd6bd to 7265467 Compare September 4, 2022 07:32
@xezon
Copy link
Collaborator

xezon commented Sep 4, 2022

Enlima29

there are 3 objects that need to be hidden in the damaged night condition: Object03, Object04 and Mesh03. For the snow damaged condition, sadly these sub-objects were welded into the main building so actual model editing need to be done (unless you want to salvage the parts from snow night damaged model and hide the night bits to look like the snow damaged model)

@commy2
Copy link
Collaborator Author

commy2 commented Sep 4, 2022

While the clipping happens on the SNOW+DAMAGED CC's and OBJECT03 is merged into the rest of the model and thus cannot be hidden by INI, at least the team colour is working correctly:

shot_20220904_110745_2

This and the lack of a model makes me think this fix is good enough, unless somebody else wants to have a go at it.

@xezon
Copy link
Collaborator

xezon commented Sep 19, 2022

Fix looks good enough.

@xezon xezon merged commit d49edd9 into main Sep 19, 2022
@xezon xezon deleted the fix-damaged-china-cc-at-night branch September 19, 2022 11:31
@xezon xezon added Art Is art related China Affects China faction labels Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related Bug Something is not working right China Affects China faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants