Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Nuke Battlemaster Uses Button And Portrait From Normal Battlemaster #1021

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Fix: Nuke Battlemaster Uses Button And Portrait From Normal Battlemaster #1021

merged 1 commit into from
Aug 29, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 29, 2022

Art is from NProject.

before / 1.04

shot_20220820_094917_1

shot_20220820_094921_2

  • same icon as normal Battlemaster, art does not resemble unit
  • button and portrait are different, portrait has radiation sign

after / patch

shot_20220820_094208_1

shot_20220820_094213_3

  • art resembles unit
  • radiation sign on button and portrait

previous: #997

@commy2 commy2 added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker labels Aug 29, 2022
xezon
xezon reviewed Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows "Git LFS file not shown" here in the TGA's

@xezon xezon force-pushed the fix-nuke-battlemaster-portrait branch from 954eb1d to afcf7aa Compare August 29, 2022 15:44
@commy2 commy2 merged commit a7c5baf into main Aug 29, 2022
@commy2 commy2 deleted the fix-nuke-battlemaster-portrait branch August 29, 2022 15:51
@xezon xezon added China Affects China faction GUI For graphical user interface and removed Design Is a matter of game design labels Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
China Affects China faction GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @xezon