fix(napi): update CI

TheOpenDictionary · Nov 18, 2024 · 6870489 · 6870489
1 parent f717247
commit 6870489
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 15 deletions.
diff --git a/.github/workflows/napi.yml b/.github/workflows/napi.yml
@@ -180,15 +180,15 @@ jobs:
             whoami
             env
             freebsd-version
-            pnpm install
+            pnpm install --no-frozen-lockfile
             pnpm --filter="@odict/node" build
             rm -rf node_modules
             rm -rf target
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
           name: bindings-freebsd
-          path: ${{ env.APP_NAME }}.*.node
+          path: bindings/node/dist/${{ env.APP_NAME }}.*.node
           if-no-files-found: error
   test-macOS-windows-binding:
     name: Test bindings on ${{ matrix.settings.target }} - node@${{ matrix.node }}
@@ -222,7 +222,7 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: bindings-${{ matrix.settings.target }}
-          path: .
+          path: bindings/node/dist
       - name: List packages
         run: ls -R .
         shell: bash
@@ -254,7 +254,7 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: bindings-x86_64-unknown-linux-gnu
-          path: .
+          path: bindings/node/dist
       - name: List packages
         run: ls -R .
         shell: bash
@@ -288,7 +288,7 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: bindings-x86_64-unknown-linux-musl
-          path: .
+          path: bindings/node/dist
       - name: List packages
         run: ls -R .
         shell: bash
@@ -311,7 +311,7 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: bindings-aarch64-unknown-linux-gnu
-          path: .
+          path: bindings/node/dist
       - name: List packages
         run: ls -R .
         shell: bash
@@ -345,7 +345,7 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: bindings-aarch64-unknown-linux-musl
-          path: .
+          path: bindings/node/dist
       - name: List packages
         run: ls -R .
         shell: bash
@@ -366,7 +366,7 @@ jobs:
           options: "--platform linux/arm64 -v ${{ github.workspace }}:/build -w /build"
           run: |
             set -e
-            pnpm  --filter="@odict/node" test
+            pnpm --filter="@odict/node" test
   test-linux-arm-gnueabihf-binding:
     name: Test bindings on armv7-unknown-linux-gnueabihf - node@${{ matrix.node }}
     needs:
@@ -384,7 +384,7 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: bindings-armv7-unknown-linux-gnueabihf
-          path: .
+          path: bindings/node/dist
       - name: List packages
         run: ls -R .
         shell: bash
@@ -433,7 +433,7 @@ jobs:
           name: bindings-aarch64-apple-darwin
           path: artifacts
       - name: Combine binaries
-        run: pnpm universal
+        run: pnpm --filter="@odict/node" universal
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
@@ -466,9 +466,9 @@ jobs:
       - name: Download all artifacts
         uses: actions/download-artifact@v4
         with:
-          path: artifacts
+          path: bindings/node/artifacts
       - name: Move artifacts
-        run: pnpm artifacts
+        run: pnpm --filter="@odict/node" artifacts
       - name: List packages
         run: ls -R ./npm
         shell: bash

diff --git a/bindings/node/package.json b/bindings/node/package.json
@@ -35,7 +35,7 @@
   "scripts": {
     "build": "napi build --release --platform --pipe \"prettier -w\" ./dist",
     "build:debug": "napi build --platform --pipe \"prettier -w\" ./dist",
-    "test": "pnpm run build && vitest --no-watch",
+    "test": "vitest --no-watch",
     "universal": "napi universal",
     "artifacts": "napi artifacts",
     "version": "napi version",

diff --git a/bindings/node/tasks.toml b/bindings/node/tasks.toml
@@ -6,6 +6,7 @@ run = "pnpm --filter=\"@odict/node\" npm publish"
 
 ["test:node"]
 run = "pnpm --filter=\"@odict/node\" test -- "
+depends = ["build:node"]
 
 ["ci:node"]
 run = "act napi --container-architecture linux/amd64 --bind --job build"

diff --git a/bindings/node/tests/dictionary.spec.ts b/bindings/node/tests/dictionary.spec.ts
@@ -20,14 +20,14 @@ describe("Dictionary", () => {
 
   beforeAll(async () => {
     dict1Path = join(
-      fileURLToPath(new URL(import.meta.url)),
+      fileURLToPath(new URL(import.meta.url), { windows: false }),
       "../../../../examples/example1.xml"
     );
 
     dict1 = await Dictionary.compile(dict1Path);
 
     dict2Path = join(
-      fileURLToPath(new URL(import.meta.url)),
+      fileURLToPath(new URL(import.meta.url), { windows: false }),
       "../../../../examples/example2.xml"
     );