Weather App: Add note about dynamic import() #29464
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Before #28347, the old weather API included icon URLs in the JSON response, so no asset imports would be needed. With VisualCrossing, they don't include any, so you'd have to gather assets (which they provide separately) and import them.
It's a common question in the community about not having to statically import loads of assets individually for dynamic JS. The help typically involves advising about exploring dynamic
import()
. At this point, learners should be able to make sense of handling async dynamic imports for this project, it just was never previously mentioned so many people have no idea it even exists.I think it's sensible to mention it and let learners decide what to do with it.
This PR
import()
function for dynamically loading bundled assetsIssue
N/A
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section