React Testing lesson: Recommend setup functions over beforeEach #29459
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Testing
Because
The current lesson suggests using
beforeEach
in Vitest for rendering components multiple times in tests. However, React Testing Library (RTL) discourages this practice in favor of using a custom setup function. This PR updates the lesson to align with best practices by recommending setup functions instead ofbeforeEach
.This PR
"For a lot of tests for a component, the
beforeEach
Vitest function could prove handy."with
"For a lot of tests for a component, a custom
setup
function could prove handy."Issue
Closes #29381
Additional Information
The change aligns with React Testing Library’s official guidance, which discourages rendering components inside
beforeEach
and recommends using a setup function instead.Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section