Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding problem when writing plist file #52

Closed
Vampire opened this issue Aug 5, 2019 · 1 comment
Closed

encoding problem when writing plist file #52

Vampire opened this issue Aug 5, 2019 · 1 comment

Comments

@Vampire
Copy link
Contributor

Vampire commented Aug 5, 2019

The plist is written to disk in the system default encoding, but no encoding is noted in the XML.
The default encoding of an XML file if no encoding is specified is UTF-8.
So the contents written are not encoded properly if you use characters from outside ASCII, like the copyright character or some special characters in names or similar.
One option would be to add the encoding as attribute to the generated plist file, but the preferable option would be to explictily specify UTF-8 as encoding when writing the file.

sreilly added a commit that referenced this issue Aug 5, 2019
@sreilly
Copy link
Contributor

sreilly commented Aug 6, 2019

Thanks @Vampire for the fix in PR #53

@sreilly sreilly closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants