Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add observableType endpoints #264

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Add observableType endpoints #264

merged 4 commits into from
Dec 15, 2022

Conversation

Black-Pearl25
Copy link
Contributor

@Black-Pearl25 Black-Pearl25 commented Nov 24, 2022 •
edited
Loading

  • Added an endpoint for observable types, the script contains four functions : create, get, delete and find. It passed the tests.

@To-om To-om requested review from Kamforka and vdebergue November 24, 2022 17:01
@Kamforka
Copy link
Collaborator

Thanks for the PR! Gonna review tomorrow!

@Kamforka
Copy link
Collaborator

CI jobs didn't trigger, can you please add the below to .github/workflows/ci.yml:

on: [push, pull_request]

@Black-Pearl25
Copy link
Contributor Author

Done.

Kamforka
Kamforka requested changes Nov 25, 2022
View reviewed changes
thehive4py/types/observable_type.py Outdated Show resolved Hide resolved
thehive4py/types/observable_type.py Outdated Show resolved Hide resolved
tests/test_observable_type_endpoint.py Outdated Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
@Kamforka
Copy link
Collaborator

Done.

I'd also recommend you to set up black locally to aid you with formatting!

@Kamforka Kamforka assigned Kamforka and Black-Pearl25 and unassigned Kamforka Nov 25, 2022
@Kamforka Kamforka added the 2.x label Nov 25, 2022
@Kamforka Kamforka added this to the 2.0.0b4 milestone Nov 25, 2022
@Black-Pearl25
Copy link
Contributor Author

Done, and thanks for the suggestion, i'll do that.

@Black-Pearl25 Black-Pearl25 requested review from Kamforka and removed request for vdebergue December 12, 2022 10:14
@Black-Pearl25 Black-Pearl25 force-pushed the observableTypesEndpoint branch from 188d01e to 6f9d9d5 Compare December 12, 2022 10:31
Kamforka
Kamforka approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@Kamforka Kamforka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just resolve the workflow conflict and it is good to go!

@Black-Pearl25
Copy link
Contributor Author

Done!

@Kamforka Kamforka merged commit cfdae09 into TheHive-Project:develop Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kamforka Kamforka Kamforka approved these changes

Assignees

@Black-Pearl25 Black-Pearl25

Labels
2.x
Projects
None yet
Milestone
2.0.0b4
Development

Successfully merging this pull request may close these issues.
2 participants
@Black-Pearl25 @Kamforka