Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IDs in all models #123

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Added IDs in all models #123

merged 1 commit into from
Jun 13, 2019

Conversation

mgabriel-silva
Copy link

Added IDs in all models
Fixes #120

@nadouani nadouani changed the base branch from master to 1.x June 13, 2019 09:09
@nadouani nadouani added this to the 1.7.0 milestone Jun 13, 2019
@nadouani nadouani merged commit 7fe5081 into TheHive-Project:1.x Jun 13, 2019
@mgabriel-silva mgabriel-silva deleted the fixIds branch June 13, 2019 16:31
@nadouani
Copy link
Contributor

nadouani commented Jul 3, 2019

We need to revert this issue since the create APIs don't allow providing ID for entities to be created.

@nadouani
Copy link
Contributor

nadouani commented Jul 3, 2019

Or a better idea, remove the id during the creation process. I'll update the jsonify function to allow an exclude arg where we can specify fields to exclude

@mgabriel-silva
Copy link
Author

It's better to let that id there. Everytime we do an update, we have to manually insert the id.
The update method requires an id, but the models didn't had it.

@nadouani
Copy link
Contributor

nadouani commented Jul 4, 2019

Yes, the change I made is to exclude the id from creation calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mgabriel-silva @nadouani