Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry mechanism to the api client #340

Closed
Kamforka opened this issue Sep 25, 2024 · 0 comments · Fixed by #344
Closed

Add retry mechanism to the api client #340

Kamforka opened this issue Sep 25, 2024 · 0 comments · Fixed by #344
Assignees
@Kamforka
Labels
2.x category:enhancement
Milestone
2.0.0b7

Comments

@Kamforka
Copy link
Collaborator

At the moment the client won't retry failed requests.

The idea is to implement a retry mechanism that is configurable via the client constructor.

The mechanism should have a default retry setup of:

  • total retries: 5
  • backoff factor: 1
  • retry on statuses: 500, 502, 503 504
  • allow retry on methods: GET, POST, PATCH, PUT, DELETE
@Kamforka Kamforka added this to the 2.0.0b7 milestone Sep 25, 2024
@Kamforka Kamforka self-assigned this Sep 25, 2024
Kamforka added a commit that referenced this issue Sep 25, 2024
@Kamforka
#340 - add codecov action
372e4eb
@Kamforka Kamforka linked a pull request Sep 25, 2024 that will close this issue
#340 - add codecov action #341
Closed
@Kamforka Kamforka mentioned this issue Sep 25, 2024
Closed
Kamforka added a commit that referenced this issue Sep 25, 2024
@Kamforka
#340 - add codecov action
748e8f9
Kamforka added a commit that referenced this issue Sep 25, 2024
@Kamforka
#340 - add codecov action
32f8635
Kamforka added a commit that referenced this issue Sep 25, 2024
@Kamforka
#340 - Add retry mechanism
d7db5c9
@Kamforka Kamforka mentioned this issue Sep 25, 2024
Merged
Kamforka added a commit that referenced this issue Sep 26, 2024
@Kamforka
#340 - Add retry mechanism
9bbd5c7
Kamforka added a commit that referenced this issue Sep 26, 2024
@Kamforka
#340 - Add retry mechanism
8689a09
Kamforka added a commit that referenced this issue Sep 26, 2024
@Kamforka
Merge pull request #344 from TheHive-Project/340-add-retry-mechanism-…
aecec9e 
…to-the-api-client

#340 - Add retry mechanism
@Kamforka Kamforka removed a link to a pull request Sep 26, 2024
#340 - add codecov action #341
Closed
@Kamforka Kamforka linked a pull request Sep 26, 2024 that will close this issue
#340 - Add retry mechanism #344
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kamforka Kamforka

Labels
2.x category:enhancement
Projects
None yet
Milestone
2.0.0b7
Development

Successfully merging a pull request may close this issue.

#340 - Add retry mechanism TheHive-Project/TheHive4py
1 participant
@Kamforka