Added Chat History and Server History #100
Conversation
There was a problem hiding this comment.
Cargo.lock needs to be removed. Not my call, but is what HB typically wants. He might have a clear reason about it but I'm not sure.
Also you touched some of the rust files, which is fine, but wasn't declared in the PR. Personally I'd make separate PRs for atomic reasons since it looks like you just did some stylistic changes, but this is fine for the moment. Okay it looks like a botched merge. I'll send over a incantation to help fix your history before you do your next push.
.dccache
Outdated
| @@ -0,0 +1 @@ | |||
| [{}] | |||
There was a problem hiding this comment.
Remove these files. Looks like residual files from a extension
KISSMultiplayer/.dccache
Outdated
| @@ -0,0 +1 @@ | |||
| [{}] | |||
kissmp-bridge/src/voice_chat.rs
Outdated
|
|
||
| info!("Using default audio output device: {}", device.name().unwrap()); | ||
|
|
kissmp-server/src/server_vehicle.rs
Outdated
| @@ -55,6 +55,7 @@ impl crate::Server { | |||
|
|
|||
| pub async fn set_current_vehicle(&mut self, client_id: u32, vehicle_id: u32) { | |||
| let connection = self.connections.get_mut(&client_id).unwrap(); | |||
| info!("set_current_vehicle vehicle = {}", vehicle_id); | |||
There was a problem hiding this comment.
Looks like a forgotten debug message.
For a bit of clarity, the source of the issue is here, ocornut/imgui#2700. For brevity, |
Added chat history (use up and down arrows) Added a clear button to clear chat Semi-fixed reloading the mod, before you would have to restart the game but now you just have to reload lua twice Co-authored-by: Carlen White <[email protected]>
|
Sent a fixed history to @vulcan-dev over Discord. |
|
Chat history is useless in my opinion, but server history is a nice feature. Seperate pull request into chat history and server history, or just remove chat history from this one |
|
Also, keep your pull requests atomized. Some of the changes are controversial |
I disagree. For just regular chatting sure, but it's useful for cases when someone needs to re-run a
But for atomizing, yeah. Might be a good idea to keep the two separate for discussion purposes. |
If you really want I can but me and a few others have wanted this for a long time, especially on my server where a lot of it is command based (I now have a UI but still aroung 80 or so commands). If someone enters an incorrect command they can't see their mistake, or say they want to do the command again then they can just press the up arrow. It's not much to maintain, it's just an extra feature that is really helpful but as I said, if you really want this gone then I can. |
|
I personally like the idea of chat history, there's configuration details that people could put in there for vehicles and stuff. |
I have added the
server history tabback, along with that I also addedchat history(use up and down arrows to cycle through previous messages you sent). There is also a clear button to clear the chat, can be useful when it's full.I also added some checks for
networkbecause if you were to reload lua, there was a good chance this wouldn't load and you would just get spammed with errors. You would need to restart the game to fix it but now you can just reload lua twice via (CTRL + L) and you're good to go.The UI colour issue when docking is also somewhat fixed. There is not full fix for this because BeamNG haven't updated it but what me and Carlen done was add some checks to see if the window is docked, if it is docked then don't apply any transparency.