Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update find_intersecting_snps_2.py and new filter_remapped_reads_2.py #2

Merged
merged 11 commits into from
Jul 14, 2016

Conversation

rmagoglia
Copy link

Updates to find_intersecting_snps_2.py:

  • Fix bug to prevent writing duplicate reads
  • Add runtime and run statistics

New filter_remapped_reads_2.py:

  • Compatible with find_intersecting_snps_2.py (no .num.gz file needed)
  • Add runtime and run statistics

rmagoglia and others added 11 commits June 20, 2016 13:12
This  is a longer message saying what I did.
Added run statistics and runtime to standard output. Fixed limit on number of SNPs allowed per read (default is 1024). Allowed for chromosome names that have a "." in them (e.g. NC_012920.1). Removed -s --sorted option, since it is not used.
Run statistics covers everything we need to print.
Script now tracks how many reads contain the reference SNP alleles given in the SNP files. The number of "reference matches"  should ideally be 100%. If this percentage is very low, it may indicte that the SNPs are incorrect or that they are not 1-indexed, etc.
Duplicates of reads were being written to the fastq files.
Changes from original version:
- No longer requires .num.gz file (now compatible with fild_intersecting_snps_2.py)
- Tracks runtime and run statistics
This variable wasn't being used for anything.
Turns out we do need this.
Script now works for reads that did not remap at all, so the remapped bam file need not contain unmapped reads. Note that the remapped bam file MUST be sorted by read name.
@rmagoglia rmagoglia merged commit 41ed66b into TheFraserLab:SimpleFindSNPs Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant