Support llvm-sys 150.x.x #383

hedgar2017 · 2022-11-17T21:10:21Z

Updates

Support the opaque pointers and all related functions.
Guard the LLVMConst* function family.
Guard some optimization passes, including those for coroutines.
Update the AtomicRMWBinOp enum.
Add conditional compilation clauses for some low-hanging functions.
Fix the AddressSpace enum and make it more generic (breaking).
Add functions for parsing LLVM IR from the memory and files.
Add the function for parsing command line options.
The bitcast operation now returns AnyType to support function pointer casts.
Some minor fixes and improvements.
Updated some dependencies.

Notes

I decided not to continue nesting in the functions which require opaque pointers, but instead implement another set of function with the suffix _2. It's not a perfect solution, but the alternative one would be worse from my point of view.
The PR wasn't yet sanitized with clippy, and some tests are probable missing. Let's discuss. Honestly I feel like the project hasn't been sanitized in multiple previous PRs as well.

Related issues

#359

Supersedes this PR

[ x ] I have read the Contributing Guide

1. Remove the `LLVMConst*` function family 2. Remove some optimization passes, including those for coroutines 3. Update the `AtomicRMWBinOp` enum

1. Remove the `LLVMConst*` function family 2. Remove some optimization passes, including those for coroutines 3. Update the `AtomicRMWBinOp` enum (cherry picked from commit 2a5b193)

(cherry picked from commit 124a088)

TheDan64 · 2022-11-25T00:27:20Z

Hmm it seems like LLVM 15 isn't yet supported in the actions build? KyleMayes/install-llvm-action#31

Cargo.toml

src/builder.rs

src/lib.rs

src/passes.rs

src/support/mod.rs

src/values/float_value.rs

TheDan64

Left a couple small comments/questions but otherwise approved. Would also like to see CI running tests for LLVM 15 but I'm not sure what we can do about the issue..

src/basic_block.rs

tests/all/test_passes.rs

tests/all/test_values.rs

folkertdev · 2022-12-21T11:35:21Z

so if we want to take this in the opaque pointer direction, one thing that still needs to happen is removing get_element_type on PointerType

TheDan64 · 2022-12-21T12:09:31Z

I thought we agreed to move opaque support into a separate PR?

folkertdev · 2022-12-21T13:38:52Z

well in that case many changes here (e.g. passing the extra arguments to load/GEP) are not required. We have now solved most of the technical issues so the only reason for that split really is that this PR is kind of big. On the other hand looking at the changes, most of them aren't very interesting. Really only the builder is interesting because type signatures change there and that means some APIs now have to be different.

anyway, up to @hedgar2017 I guess. I can report that this branch already works very well for my purposes.

hedgar2017 · 2022-12-21T13:53:34Z

@folkertdev this branch works for me perfectly as well.
On the contrary, I'll probably need to adjust my FE for the changes you propose, so I fully support the idea to proceed in another PR.
For now I use my custom branch which I'm going to rebase onto this one when this PR is merged.

@TheDan64 give me 1 sec, I'll fix those values I've missed for some reason.

hedgar2017 · 2022-12-21T13:58:13Z

@TheDan64 please re-run the CI.

TheDan64 · 2022-12-23T08:09:58Z

Is this ready for final review, then?

hedgar2017 · 2022-12-23T13:49:13Z

Is this ready for final review, then?

Yes. Requested.

TheDan64

I'm giving this a soft approval - had a couple questions to address before merging.

Thanks for everyone who helped contribute!

examples/kaleidoscope/implementation_typed_pointers.rs

src/builder.rs

tests/all/test_instruction_values.rs

tests/all/test_passes.rs

src/types/ptr_type.rs

hedgar2017 · 2023-01-15T12:21:07Z

@TheDan64 I've landed some fixes. Please re-run the CI!

hedgar2017 · 2023-01-16T10:03:51Z

@TheDan64 fixed, please re-run.

hedgar2017 · 2023-01-17T16:44:32Z

@TheDan64 fixed, please re-run :)
(sorry, for some reason doc tests didn't run for me locally)

ksolana and others added 7 commits October 31, 2022 17:12

Support llvm-15 for inkwell

3a97796

Add llvm15-0 to supported features

fffe576

Add the zkSync VM local changes

9dacd28

Add the LLVMParseCommandLineOptions binding

09c83e7

Change the dependencies protocol to HTTPS

30efb42

Make 'inkwell' compiler with LLVM 15

2a5b193

1. Remove the `LLVMConst*` function family 2. Remove some optimization passes, including those for coroutines 3. Update the `AtomicRMWBinOp` enum

Make 'inkwell' compile with LLVM 15

47bd6a0

1. Remove the `LLVMConst*` function family 2. Remove some optimization passes, including those for coroutines 3. Update the `AtomicRMWBinOp` enum (cherry picked from commit 2a5b193)

hedgar2017 marked this pull request as draft November 17, 2022 21:14

Alex Z added 6 commits November 19, 2022 00:25

Support load2 and gep2

82ca8f5

Support the rest of GEPs and ptr_diff

7138801

Support call_2 and invoke_2

952f33b

Fix tests for passes and debug info

eb77041

Update the tests

4330a51

Merge branch 'llvm-15' into az/update-llvm-15-support

0bd11e5

hedgar2017 force-pushed the az/update-llvm-15-support branch from 4751e93 to 0bd11e5 Compare November 24, 2022 13:03

Merge branch 'master' into az/update-llvm-15-support

3f3a8a4

hedgar2017 marked this pull request as ready for review November 24, 2022 13:06

Alex Z added 2 commits November 24, 2022 15:12

Remove the local target artifacts

abeb758

Restore the deprecated passes and const functions

dee5b78

hedgar2017 mentioned this pull request Nov 24, 2022

LLVM 15 support #359

Closed

Remove a function type check

5fedbd3

(cherry picked from commit 124a088)

TheDan64 self-requested a review November 27, 2022 02:38

TheDan64 assigned hedgar2017 Nov 27, 2022

TheDan64 reviewed Nov 27, 2022

View reviewed changes

Alex Z added 2 commits November 27, 2022 11:14

Remove function extensions, fix LLVM version deps

ea49435

Remove the command line arguments parsing function

34c30f8

hedgar2017 requested a review from TheDan64 November 27, 2022 09:18

Remove another function type check

b0ae971

TheDan64 approved these changes Dec 2, 2022

View reviewed changes

src/basic_block.rs Show resolved Hide resolved

tests/all/test_passes.rs Show resolved Hide resolved

tests/all/test_values.rs Outdated Show resolved Hide resolved

hedgar2017 requested review from TheDan64 and folkertdev and removed request for TheDan64 and folkertdev December 21, 2022 10:30

Fix some compile errors and warnings

7197862

baszalmstra mentioned this pull request Jan 4, 2023

bump: upgrade to LLVM 14 mun-lang/mun#488

Closed

TheDan64 reviewed Jan 7, 2023

View reviewed changes

Some types and tests fixes

8a01251

Fix the LLVM 8 compile error

5f978cb

Try conditional compilation on doc tests

0ab9377

TheDan64 merged commit 55770a8 into TheDan64:master Jan 18, 2023

TheDan64 mentioned this pull request Jan 18, 2023

Opaque pointers #382

Closed

Pat-Lafon mentioned this pull request Jan 18, 2023

Update Readme with llvm15 feature flags #388

Merged

1 task

hedgar2017 deleted the az/update-llvm-15-support branch January 18, 2023 06:43

Support llvm-sys 150.x.x #383

Support llvm-sys 150.x.x #383

Uh oh!

Conversation

hedgar2017 commented Nov 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updates

Notes

Related issues

Uh oh!

TheDan64 commented Nov 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheDan64 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

folkertdev commented Dec 21, 2022

Uh oh!

TheDan64 commented Dec 21, 2022

Uh oh!

folkertdev commented Dec 21, 2022

Uh oh!

hedgar2017 commented Dec 21, 2022

Uh oh!

hedgar2017 commented Dec 21, 2022

Uh oh!

TheDan64 commented Dec 23, 2022

Uh oh!

hedgar2017 commented Dec 23, 2022

Uh oh!

TheDan64 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hedgar2017 commented Jan 15, 2023

Uh oh!

hedgar2017 commented Jan 16, 2023

Uh oh!

hedgar2017 commented Jan 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hedgar2017 commented Nov 17, 2022 •

edited

Loading