Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VBR wrapper outputs 128 kbit mp3 #29

Closed
DjRicko opened this issue Apr 11, 2022 · 4 comments
Closed

VBR wrapper outputs 128 kbit mp3 #29

DjRicko opened this issue Apr 11, 2022 · 4 comments
Assignees
@TheCaptain989
Labels
bug Something isn't working

Comments

@DjRicko
Copy link

DjRicko commented Apr 11, 2022

The VBR wrapper script seems to suddenly output 128 kbit mp3 instead of -V0 VBR?
Think this started with the additional codec support being added. But can't seem to find where the logic is broken in the code.
@TheCaptain989 TheCaptain989 self-assigned this Apr 12, 2022
@TheCaptain989
Copy link
Owner

Hmmm. Let me look into that one.

@TheCaptain989 TheCaptain989 added the bug Something isn't working label Apr 12, 2022
@TheCaptain989
Copy link
Owner

TheCaptain989 commented Apr 12, 2022 •
edited
Loading

Weird. It looks like a subtle bug that was introduced in release 1.3 with commit b6fc4fb.
Fixing it now...

TheCaptain989 added a commit that referenced this issue Apr 12, 2022
@TheCaptain989
Release 2.0 candidate 2
bee6f8e 
- Bug fix for issue #29 introduced with release 1.3
@TheCaptain989
Copy link
Owner

@DjRicko, Please test out the fix using this dev repo and let me know.

TheCaptain989 referenced this issue Apr 12, 2022
@TheCaptain989
Update to 1.3
b6fc4fb 
-Added advanced -a and -e options
-Can convert to any ffmpeg supported format
@DjRicko
Copy link
Author

DjRicko commented Apr 12, 2022

@DjRicko, Please test out the fix using this dev repo and let me know.

Works perfectly again now, thanks alot for your great work. :)

@DjRicko DjRicko closed this as completed Apr 12, 2022
@TheCaptain989 TheCaptain989 mentioned this issue May 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCaptain989 TheCaptain989

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DjRicko @TheCaptain989