Accept invalid/self-signed SSL certificates #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @TheBinitGhimire,
Fix for: https://twitter.com/WHOISbinit/status/1357018526171553792
The issue was that the module
reqwest
doesn't allow connecting to a host with invalid/self-signed SSL certificates as it could introduce vulnerabilities (As mentioned in docs). But for use cases like this, we can override it with.danger_accept_invalid_certs()
.I believe this solves the issue as a whole. I tested with a random IP I found with invalid certificate and it doesn't reach
Err(_)
.Also compiles without any warnings too. 👍
Nice project and Good Luck! 🙌❤️