Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept invalid/self-signed SSL certificates #4

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Accept invalid/self-signed SSL certificates #4

merged 1 commit into from
Feb 4, 2021

Conversation

mufeedvh
Copy link
Contributor

@mufeedvh mufeedvh commented Feb 4, 2021

Hey @TheBinitGhimire,

Fix for: https://twitter.com/WHOISbinit/status/1357018526171553792

The issue was that the module reqwest doesn't allow connecting to a host with invalid/self-signed SSL certificates as it could introduce vulnerabilities (As mentioned in docs). But for use cases like this, we can override it with .danger_accept_invalid_certs().

I believe this solves the issue as a whole. I tested with a random IP I found with invalid certificate and it doesn't reach Err(_).

Screenshot from 2021-02-04 12-59-28

Also compiles without any warnings too. 👍

Nice project and Good Luck! 🙌❤️

@AkashHamal0x01-zz
Copy link

hope this PR gets accepted :)

Copy link
Owner

@TheBinitGhimire TheBinitGhimire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mufeedvh,

Thank you for your contribution to the development of NtHiM!

I checked your commit, and since all checks have passed, and the code compiles without any warnings or errors, I decided to test whether it resolves the issue for invalid or self-signed SSL certificates or not. During my test, the results were as expected, which means your commit resolves the issue.

I have sent you a bounty amount of $13.37 in Bitcoin to your Coinbase wallet as we discussed about the payout method on Twitter.

The following image provides the information about the bounty amount as I tweeted about it on Twitter:

NtHiM Bounty

Again, thank you for your contribution!

I am approving your changes for now, and will merge your Pull Request.

Thanks,
Binit Ghimire
@TheBinitGhimire

@TheBinitGhimire TheBinitGhimire merged commit a5a3a47 into TheBinitGhimire:main Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants