Skip to content

Conversation

@BD103
Copy link
Member

@BD103 BD103 commented Jul 3, 2025

Closes #506, follow up to #456.

This is a relatively simple upgrade, only two changes affected us:

  • ItemKind::Struct and ItemKind::Enum's fields were reordered.
  • GenericArg::unpack() was renamed to GenericArg::kind().

With this, we're all caught up to Rust's language latest beta language features!

@BD103 BD103 added A-Linter Related to the linter and custom lints C-Dependencies A change related to dependencies M-Needs-Migration-Guide A breaking change to the public API that needs to be noted in the migration guide S-Needs-Review The PR needs to be reviewed before it can be merged labels Jul 3, 2025
BD103 added 3 commits July 3, 2025 15:14
The `Interner` trait was only introduced so that `rustc_type_ir` didn't have to depend on `rustc_middle`. This isn't a problem for us, so we can use `TyCtxt` directly.
@BD103

This comment was marked as resolved.

@BD103 BD103 added this to the `bevy_lint` v0.4.0 milestone Jul 8, 2025
Copy link
Collaborator

@DaAlbrecht DaAlbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! the past few upgrades have been pretty easy. Thanks as always that you take care of them <3

if web_args.wasm_opt.is_empty() {
web_args.wasm_opt = config.wasm_opt(is_release).to_raw();
}
if let Some(BuildSubcommands::Web(web_args)) = self.subcommand.as_mut()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahahha sneaky (;

@DaAlbrecht DaAlbrecht merged commit 8913dc3 into main Jul 11, 2025
13 checks passed
@DaAlbrecht DaAlbrecht deleted the nightly-2025-06-02 branch July 11, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Related to the linter and custom lints C-Dependencies A change related to dependencies M-Needs-Migration-Guide A breaking change to the public API that needs to be noted in the migration guide S-Needs-Review The PR needs to be reviewed before it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade linter to nightly-2025-06-26 toolchain

3 participants