Skip to content

Talk about "application", not "AppImage" #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Talk about "application", not "AppImage" #184

wants to merge 2 commits into from

Conversation

probonopd
Copy link
Contributor

@probonopd probonopd commented Jul 3, 2019 •
edited
Loading

TheAssassin
TheAssassin requested changes Jul 3, 2019
View reviewed changes
src/shared/shared.cpp
}

#ifdef ENABLE_UPDATE_HELPER
#ifdef ENABLE_+_HELPER
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That breaks things completely. Might have been an accidental change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I change this? Must have been inadvertently. I just want "AppImage" to be replaced with "application".

@TheAssassin
Copy link
Owner

TheAssassin commented Jul 3, 2019 •
edited
Loading

I don't like this change. We must differentiate between "system wide apps" and "user-local AppImages". The desktop action is missing for regular system apps. To not confuse people, the term AppImage is better here.

@TheAssassin TheAssassin closed this Jul 3, 2019
@probonopd
Copy link
Contributor Author

probonopd commented Jul 3, 2019 •
edited
Loading

Please reconsider if you want this tool to replace any of my tools.

@probonopd
Copy link
Contributor Author

Feel free to use the AppImage icon if you think this makes this change more feasible.

@TheAssassin
Copy link
Owner

That might be a better UX then. When the AppImage icon is used, it gets pretty clear to a user that these are AppImage only features. That's IMO a good thing, to be honest. It advertises this "if you use AppImage, your life becomes easier" thing we're working on, as other applications don't have such an easy UX. That's the thing I want to highlight.

@probonopd
Copy link
Contributor Author

Hence, please reopen.

@TheAssassin TheAssassin reopened this Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheAssassin TheAssassin TheAssassin requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extraneous launcher entries in KDE Plasma

2 participants

@probonopd @TheAssassin