Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build.sh executable via post-action #37

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Feb 9, 2018

@TheAngryByrd
Copy link
Owner

🎸

@TheAngryByrd TheAngryByrd merged commit 7e392b6 into TheAngryByrd:master Feb 9, 2018
TheAngryByrd pushed a commit that referenced this pull request Feb 9, 2018
* BUGFIX: Make build.sh executable via post-action (#37)
* MINOR: Add Release notes to git release commits (#39)
@TheAngryByrd
Copy link
Owner

@rmunn just released 0.4.1-beta002 if you want to test it out

@rmunn
Copy link
Contributor Author

rmunn commented Feb 10, 2018

Tried out 0.4.1-beta002 by downloading the NuGet package manually and then running dotnet new -i /home/rmunn/Downloads/miniscaffold.0.4.1-beta002.nupkg. (I couldn't figure out how to get dotnet new to give me prerelease NuGets; running dotnet new -i "MiniScaffold::*" just gave me 0.4.0). It opened up with an executable build.sh file. Had a different problem, which I also encountered with 0.4.0, where the FAKE package didn't get restored so build.sh failed — but I'll open a separate bug report for that one. As far as the post-install script goes, it works.

And BTW, if anyone tries to install this via dotnet new on .Net Core versions before 2.0.0, they won't get an exectuable build.sh script (because that particular post-action was introduced in .Net Core 2.0.0), but they will see the "Run 'chmod +x *.sh'" text associated with that post-action. Props to the .Net Core team for thinking through how that would work and putting forward-compatibility into their post-action system.

@TheAngryByrd
Copy link
Owner

I think if you give it the "exact" version. ``dotnet new -i MiniScaffold::0.4.1-beta002`

@TheAngryByrd
Copy link
Owner

Also I'll make a note in the readme about it! Thanks!

TheAngryByrd pushed a commit that referenced this pull request Feb 10, 2018
* BUGFIX: Make build.sh executable via post-action (#37)
* BUGFIX: FAKE not restoring on initial build. Exclude paket-files directory from template (#42)
* MINOR: Add Release notes to git release commits (#39)
TheAngryByrd pushed a commit that referenced this pull request Feb 10, 2018
* BUGFIX: Make build.sh executable via post-action (#37)
* BUGFIX: FAKE not restoring on initial build. Exclude paket-files directory from template (#42)
* MINOR: Add Release notes to git release commits (#39)
@rmunn
Copy link
Contributor Author

rmunn commented Feb 23, 2018

Apparently the condition should have been "(OS != \"Windows_NT\")" (see dotnet/templating#1421 (comment)). I've opened PR #51 to fix that mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dotnet new mini-scaffold" on Linux strips execute bit from build.sh
2 participants