Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Environments for Nuget Publish #285

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Use GitHub Environments for Nuget Publish #285

merged 2 commits into from
Nov 19, 2023

Conversation

PolinaSavelyeva
Copy link
Contributor

Proposed Changes

Fix #284

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

I'm not sure that publishing is working quite as expected.

Copy link
Owner

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheAngryByrd TheAngryByrd enabled auto-merge (squash) November 19, 2023 17:10
@TheAngryByrd TheAngryByrd changed the title Fix nuget publish Use GitHub Environments for Nuget Publish Nov 19, 2023
@TheAngryByrd TheAngryByrd enabled auto-merge (squash) November 19, 2023 17:10
@TheAngryByrd TheAngryByrd merged commit e10f412 into TheAngryByrd:master Nov 19, 2023
7 checks passed
TheAngryByrd added a commit that referenced this pull request Nov 19, 2023
## [0.37.1] - 2023-11-19

### Fixed
- [Use GitHub Environments for Nuget Publish](#285) from @PolinaSavelyeva
@PolinaSavelyeva PolinaSavelyeva deleted the fix-nugetpublish branch July 6, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect release guide on github pages
2 participants