Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable requiring msbuild.structuredlogger always being up to date #279

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

TheAngryByrd
Copy link
Owner

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd merged commit a886b79 into master Sep 18, 2023
6 checks passed
@TheAngryByrd TheAngryByrd deleted the disable-need-for-msbuild-structuredlogger branch September 18, 2023 02:21
TheAngryByrd added a commit that referenced this pull request Sep 18, 2023
## [0.35.2] - 2023-09-17

### Fixed
- [Ensure .fantomasignore is used](#278) from @TheAngryByrd
- [Disable requiring msbuild.structuredlogger always being up to date](#279) from @TheAngryByrd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant