Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated test cases of power_sum.py #9978

Merged
merged 9 commits into from
Oct 14, 2023
Merged

Updated test cases of power_sum.py #9978

merged 9 commits into from
Oct 14, 2023

Conversation

Muhammadummerr
Copy link
Contributor

Describe your change:

I reduced the test cases, so it will run faster than before

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 7, 2023
@Muhammadummerr
Copy link
Contributor Author

The issue remains unresolved.

@Muhammadummerr
Copy link
Contributor Author

power_sum.py has been removed from that list :)

@Muhammadummerr
Copy link
Contributor Author

@cclauss

@Muhammadummerr Muhammadummerr mentioned this pull request Oct 9, 2023
Closed
8 tasks
tianyizheng02
tianyizheng02 requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also modify the code to use the ** operator instead of the pow function from math?

backtracking/power_sum.py Outdated
@@ -90,4 +90,5 @@ def solve(needed_sum: int, power: int) -> int:
if __name__ == "__main__":
import doctest

# print(backtrack(80, 1, 1, 0, 0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to keep this line of code?

@tianyizheng02
Copy link
Contributor

Also, please put the issue number in your PR's description:

  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

This way, GitHub can automatically link your PR to the original issue. However, don't use the word "fixes", because your PR doesn't completely fix the issue on its own.

@cclauss
Copy link
Member

cclauss commented Oct 10, 2023

On your computer, please run:
time python3 -m doctest backtracking/power_sum.py
on both the new code and the old code so we know how much faster the new code is.

@Muhammadummerr
Copy link
Contributor Author

OLD CODE
TotalSeconds : 2.757677
TotalMilliseconds : 2757.677

NEW CODE
TotalSeconds : 1.067801
TotalMilliseconds : 1067.801

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 13, 2023
tianyizheng02
tianyizheng02 approved these changes Oct 14, 2023
View reviewed changes
backtracking/power_sum.py Outdated Show resolved Hide resolved
@tianyizheng02
Copy link
Contributor

Contributes to #9718

@tianyizheng02 tianyizheng02 merged commit 37cae3f into TheAlgorithms:master Oct 14, 2023
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Muhammadummerr @tianyizheng02 @cclauss