Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated prime_numbers.py testcases. #9851

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Updated prime_numbers.py testcases. #9851

merged 2 commits into from
Oct 5, 2023

Conversation

Muhammadummerr
Copy link
Contributor

Describe your change:

I reduced the test cases, so it will run faster than before.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 5, 2023
@Muhammadummerr Muhammadummerr mentioned this pull request Oct 5, 2023
Closed
8 tasks
cclauss
cclauss reviewed Oct 5, 2023
View reviewed changes
maths/prime_numbers.py Outdated
Comment on lines 100 to 102
print(timeit("slow_primes(1_000)", setup=setup, number=1_000))
print(timeit("primes(1_000)", setup=setup, number=1_000))
print(timeit("fast_primes(1_000)", setup=setup, number=1_000))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these three lines. pytest does not run the code in __main__() so it does not run the benchmarks.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023
@cclauss cclauss merged commit cffdf99 into TheAlgorithms:master Oct 5, 2023
3 checks passed
@cclauss
Copy link
Member

cclauss commented Oct 5, 2023

Well done! Thanks.

@Muhammadummerr
Copy link
Contributor Author

Thank you. It means a lot to me.

@tianyizheng02
Copy link
Contributor

Contributes to #9718 (adding for linking purposes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Muhammadummerr @cclauss @tianyizheng02