Skip to content

Refactorings #8987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianyizheng02 merged 3 commits into from
Aug 20, 2023
Merged

Refactorings #8987

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc74456
use np.dot
tosemml Aug 18, 2023
c9871e7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 18, 2023
244ec40
further improvements using array slicing
tosemml Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions arithmetic_analysis/gaussian_elimination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ def retroactive_resolution(

x: NDArray[float64] = np.zeros((rows, 1), dtype=float)
for row in reversed(range(rows)):
total = 0
for col in range(row + 1, columns):
total += coefficients[row, col] * x[col]

total = np.dot(
[coefficients[row, col] for col in range(row + 1, columns)],
[x[col] for col in range(row + 1, columns)],
)
x[row, 0] = (vector[row] - total) / coefficients[row, row]

return x
Expand Down