Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing the root node in binary_search_tree.py removes the whole tree #8752

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Fix removing the root node in binary_search_tree.py removes the whole tree #8752

merged 2 commits into from
Jun 18, 2023

Conversation

Frank-1998
Copy link
Contributor

@Frank-1998 Frank-1998 commented May 20, 2023 •
edited by cclauss
Loading

Describe your change:

Fixes: #8715
Fixes: #8819

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 20, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels May 20, 2023
@tianyizheng02
Copy link
Contributor

tianyizheng02 commented May 21, 2023 •
edited
Loading

Fixes #8715

Apparently it doesn't work unless the creator of the PR does it... @Frank-1998 could you add that to your PR description so that GitHub automatically links the issue?

@Frank-1998
Copy link
Contributor Author

@tianyizheng02 Sorry, could you please explain what should I add here? I am a bit confused. Thank you.

@tianyizheng02
Copy link
Contributor

@Frank-1998 You should add Fixes #8715 to your PR description so that GitHub links this PR to the issue that it fixes. Here's an example of another PR to show you what it should look like:
screenshot
Once you do that, you should see something like this on the right side of the page:
screenshot
Once you do this, GitHub will automatically close the linked issue when this PR is approved and merged.

@Frank-1998
Copy link
Contributor Author

@tianyizheng02 Oh, I see, it's done, thank you very much. :)

@cclauss cclauss mentioned this pull request May 25, 2023
Closed
@CaedenPH CaedenPH mentioned this pull request Jun 18, 2023
Closed
14 tasks
@cclauss cclauss changed the title fix issue #8715 Fix removing the root node in binary_search_tree.py removes the whole tree Jun 18, 2023
@cclauss cclauss merged commit b0f8710 into TheAlgorithms:master Jun 18, 2023
@tianyizheng02 tianyizheng02 mentioned this pull request Jun 20, 2023
Closed
14 tasks
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Frank-1998 @pre-commit-ci @sedatguzelsemme
Fix removing the root node in binary_search_tree.py removes the whole…
a680a0e 
… tree (TheAlgorithms#8752)

* fix issue TheAlgorithms#8715

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing the root node in binary_search_tree.py removes the whole tree.
4 participants
@Frank-1998 @tianyizheng02 @cclauss @CaedenPH