fix: consider months and days in years_old
#11234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
awaiting reviews
5 tasks
algorithms-keeper
bot
removed
the
tests are failing
cclauss
changed the title
calculate_ageyears_old
cclauss
approved these changes
Jan 12, 2024
algorithms-keeper
bot
removed
the
awaiting reviews
cclauss
added a commit
to cclauss/Python
that referenced
this pull request
Jan 13, 2024
* fix: do not consider months in `calculate_age` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update get_top_billionaires.py * Update get_top_billionaires.py * Update get_top_billionaires.py * TODAY = datetime.utcnow() * Update get_top_billionaires.py * Update build.yml --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
The doc-tests of
calculate_agecan fail depending on current time - all of the builds fail now (i.e. 01.2024). I suggest to simplify thecalculate_agein such a way, that it will not take months into account (in general: the test is a specification of the function, so such approach is justified).When this will be merged, I will rebase #11233, so the CI there will pass.
Checklist: