Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ipv4_conversion.py #11008

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Create ipv4_conversion.py #11008

merged 6 commits into from
Oct 28, 2023

Conversation

Shocker-lov-t
Copy link
Contributor

@Shocker-lov-t Shocker-lov-t commented Oct 26, 2023

Describe your change:

Closes #9718
Closes #11013

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 26, 2023
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 26, 2023
15 tasks
'10.0.0.255'
"""

if not (0 <= decimal_ip <= 4294967295):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not catch 10.0.0.256 which is not a valid IP.

Shocker-lov-t

This comment was marked as off-topic.

for part in ip_parts:
decimal_ip = (decimal_ip << 8) + int(part)

return decimal_ip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def alt_ip_to_decimal(ip_address: str) -> int:
    return int("0x" + "".join(f"{int(i):02x}" for i in ip_address.split(".")), 16)

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 26, 2023
@cclauss cclauss self-assigned this Oct 27, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 28, 2023
@cclauss cclauss changed the title Create ipconversion.py Create ipv4_conversion.py Oct 28, 2023
@cclauss cclauss enabled auto-merge (squash) October 28, 2023 22:47
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@cclauss cclauss merged commit aa5c97d into TheAlgorithms:master Oct 28, 2023
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speedup our eight slowest pytests (one at a time please)
2 participants